don't flag rewind as initialized until after we're able to validate against core info #15983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where achievement code may try to enable rewind before the core info is initialized, preventing rewind from being enabled later once the core info is available.
My solution is to move the "rewind already initialized" flag logic down a few lines so it's not set unless we're actually able to attempt to initialize rewind.
It looks like the "already initialized" flag was added to prevent spamming the log (see #13741). As the lack of a core info doesn't generate a log entry, I believe this change to be benign.
Related Issues
#15933 (comment)
Related Pull Requests
n/a
Reviewers
@jdgleaver