Fix quit on content close option #16014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now close is based on core unload. There are several places where cores are unloaded without the intention of stopping the emulation (for instance whenever Netplay is started, core is updated, etc). Moreover scheduling a quit under some of those events causes a task queue deadlock (as per issue libretro#15313) and freezed retroarch. This fix moves the quit on close to a "manual" check, placed in the relevant places (close content menu option, close content event (which also covers hotkeys), etc.)
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
Right now close is based on core unload. There are several places where cores are unloaded without the intention of stopping the emulation (for instance whenever Netplay is started, core is updated, etc). Moreover scheduling a quit under some of those events causes a task queue deadlock (as per issue libretro#15313) and freezed retroarch. This fix moves the quit on close to a "manual" check, placed in the relevant places (close content menu option, close content event (which also covers hotkeys), etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now close is based on core unload. There are several places where cores are unloaded without the intention of stopping the emulation (for instance whenever Netplay is started, core is updated, etc).
Moreover scheduling a quit under some of those events causes a task queue deadlock (as per issue #15313) and freezed retroarch.
This fix moves the quit on close to a "manual" check, placed in the relevant places (close content menu option, close content event (which also covers hotkeys), etc.)