(cheevos) include achievement state in netplay states #17416
Conversation
|
So if I understand your description right this shouldn't introduce any netplay backwards compatibility issues with clients older than the version we are about to merge? As in a user from 1.20.0 stable can still netplay with someone using a hypothetical 1.21.0 stable later down the line? |
|
Yes. I was able to connect to a 1.20 stable release host with this code as a client, and connect a 1.20 client to this code as a host. The only thing that changed at the protocol level is the content of the |
Description
Netplay uses special save states to keep clients in sync with the server, but those save states don't include achievement state. As a result, the achievement state can still get desynchronized.
This PR updates the
NETPLAY_CMD_LOAD_SAVESTATEnetplay command to also pass the achievement state for protocol version 7 (the raw core snapshot will still be passed for protocols 5 and 6). I considered providing a new command, but the command just copies the data into a buffer and the processing occurs elsewhere.Also fixes an issue where achievement processing was not occurring if the game continued to run behind the menu (netplay Allow Pausing is off or Pause Content when Menu is Active is off).
Related Issues
n/a
Related Pull Requests
n/a
Reviewers
Anyone knowledgeable about the netplay code, or who has opinions on the netplay protocol.
I've tested this code connecting to this code with various states of achievement enablement both with active client and spectating client. I've also tested this code connecting to 1.20 code (both as client and as server) with achievements enabled. All testing has been using LAN hosts (mostly two instances on the same machine). Testing sessions have been limited to a few minutes per configuration and mostly just playing from the host and making sure the client reflected the host state.