Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ax_pthread macro to serial 31 #3

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

mywave82
Copy link
Contributor

No description provided.

@mywave82 mywave82 merged commit 17e586a into libsidplayfp:master Dec 25, 2023
3 checks passed
@mywave82 mywave82 deleted the update-m4-ax_pthread branch December 25, 2023 11:52
@f00b4r0
Copy link
Member

f00b4r0 commented Dec 25, 2023

@mywave82 hi, that PR and commit were completely unnecessary, ax_pthread.m4 was already at serial 31, your commit is a 0-change one. Please don't hastily commit unneeded changes without at least a second pair of eyes checking. Please also provide relevant info in your PR message. Thanks

I deleted that empty commit so as not to confuse downstream, as it suggested that ax_pthread.m4 was only updated to serial 31 today, instead of 2 years ago.

@mywave82
Copy link
Contributor Author

I am sorry that I was off course. The origin is that libsidplayfp points to an old commit in the master branch

https://github.com/libsidplayfp/libsidplayfp/tree/master/src/builders/exsid-builder
9d8b572

which triggered a warning in the autoconf toolchain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants