Nested Items in Table Widgets #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use YTable::setAlignment() instead. But for all of libyui-ncurses-pkg it was always the default left alignment anyway.
joseivanlopez
changed the title
joseivanlopez
approved these changes
Oct 9, 2020
mvidner
pushed a commit
to mvidner/libyui-combined-alpha-2
that referenced
this pull request
Dec 14, 2020
…-tree-table-01 Nested Items in Table Widgets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master PR
libyui/libyui-old#171 Edit 2021-08-10: Link updated
This is the NCurses-Pkg part.
Changes
Sorting now works differently; this is adapted to the new way in NCTable. Actually, this is now even simpler here.
After fixing a long-standing weirdness that always forced a caller to provide an alignment letter for each column when setting table headers, this is now fixed: We no longer need to set
LName,LSize. This also simplified the sources. Plus, everywhere in NCurses-Pkg it was always just the default "align left" (L), so this was just more cruft in the code.The documented way would be anyway to call
YTable::setAlignment( column ). This magic letter was always specific to the NCPad. This is now cleaned up on the base class level (NCTablePadBase).