Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChallengeSentType no longer needed #992

Merged

Conversation

MarkZH
Copy link
Collaborator

@MarkZH MarkZH commented Jul 21, 2024

Type of pull request:

  • Bug fix
  • Feature
  • Other

Description:

The Lichess API was updated so that the JSON response to creating a challenge is no longer nested under a single challenge heading. All information has been moved to the top level. This commit aligns lichess-bot with the API change.

Related Issues:

Closes #991.

Related Lichess API issue: lichess-org/api#363

Checklist:

  • I have read and followed the contribution guidelines.
  • I have added necessary documentation (if applicable).
  • The changes pass all existing tests.

Screenshots/logs (if applicable):

N/A

The Lichess API was updated so that the JSON response to creating a
challenge is no longer nested under a single `challenge` heading. All
information has been moved to the top level. This commit aligns
lichess-bot with the API change.

Closes lichess-bot-devs#991.
@AttackingOrDefending
Copy link
Member

Can you add finalColor to ChallengeType? It was added in the above-mentioned lichess-api PR.

@MarkZH
Copy link
Collaborator Author

MarkZH commented Jul 22, 2024

Can you add finalColor to ChallengeType? It was added in the above-mentioned lichess-api PR.

It's already there:

finalColor: str

@AttackingOrDefending AttackingOrDefending merged commit 38ab296 into lichess-bot-devs:master Jul 22, 2024
15 checks passed
@MarkZH MarkZH deleted the challenge-response-format branch July 22, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants