feat: add detail view to game history screen

[tom-anders]

Had this lying around for a while, got the time today to include the feedback I got on the original draft I posted in the issue. Closes #947

[ijm8710]

Hmm excited for the accuracy number to have a way back in but I prefer your old draft in some other places

I still think the actual variant/time should show and so I preferred the time/game type display of before

And the opponent name seems bigger? Especially if you try to show rating change the huge name with just the opponent and not yourself probably makes that a harder obstacle?

[veloce]

It looks quite nice!! thank you. I'd see the accuracy in even smaller font and a little more transparent. I know some people here really want to see it, but it is least important item here, so should have less emphasis while still being here.

Looks like you also implemented a grid view, judging by the icon. Can we see the screenshot for it as well please?

[tom-anders]

It looks quite nice!! thank you. I'd see the accuracy in even smaller font and a little more transparent. I know some people here really want to see it, but it is least important item here, so should have less emphasis while still being here.

Thanks, will take a look

Looks like you also implemented a grid view, judging by the icon. Can we see the screenshot for it as well please?

Oh, that's a bug actually, it should show a different icon. Pressing that icon/button will switch the view to the "old" list view

[veloce]

Oh, I thought it would be a grid view like in the puzzle history. Could make sense by the way, it would show more games at once. But not needed in this PR I guess.

I'm not sure about having the switch icon to see the old list. We probably should display the new list only (perhaps keeping the old list preview on home page only).

[tom-anders]

Oh, I thought it would be a grid view like in the puzzle history. Could make sense by the way, it would show more games at once. But not needed in this PR I guess.

I'm not sure about having the switch icon to see the old list. We probably should display the new list only (perhaps keeping the old list preview on home page only).

Will do 👍

Yeah I thought the old list is more compact and doesn't take as much space, so I kept it on the home page.

[julien4215]

Would it make sense to keep both views ? Since the list view is more compact, it can be faster to find a game that is far in the history and you can also glance more games at once.

[veloce]

I don't know, need to think about it. I don't like adding too much toggles and settings. We're fetching the same number of games per page, so it is just a matter of vertical space. If the new view allows to quickly see the important information (player name, end position), it could be that the new view would allow to find even more quickly the games.

[ijm8710]

Just a minor example (but one of a few) is it like on homepage currently when scanning an opponents games you can see a day ago, 3 days ago etc.

But when you dive into this detailed view its time stamped.

If all views including the first 10 on homepage were just timestamp you have to think more to be like is October 2nd a day ago, few days ago etc

Actually another idea here:
I prefer if it said 20 hours ago etc (but clicking that turns it into the actual time)!

I also think the compact current view does a better job to quickly scan wins and losses since it's not caught in the clutter.
And it's easier to quickly see if a game has computer analysis pulled yet.

I still think there is a bit more refinement that can be done before this becomes the official game list.
Still hoping we can see rating change
And I think it's worthwhile info to show what the variant was (ie 5+0)

[tom-anders]

A note about the time stamps: I agree that "3 days ago" is better than a full date, but for longer times I actually prefer the full date. "2023-07-24" is more helpful than "3 months" ago IMO. I think there should be some kind of cut off where we switch from "x ago" to the full date.

[tom-anders]

Also, I really like how the old app says "Last Sunday" instead of "2 days ago", I think this is more helpful as well, but probably something for another PR

[ijm8710]

What are your thoughts Tom on relative date that can be tapped to Change to actual date or with a popup.

I could have sworn GitHub used to do this. I think I've seen this with a few other apps.

[tom-anders]

What are your thoughts Tom on relative date that can be tapped to Change to actual date or with a popup.

I could have sworn GitHub used to do this. I think I've seen this with a few other apps.

idk, might be too much complexity, but not for me to decide

[tom-anders]

Did some style adjustments, removed the old list view, added rating diffs: