obsidian--match-files finds all files with given basename & more #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When issue licht1stein#64 was opened, obsidian--match-files was lazy, only the suffix was checked, so it found for 'aa.md' both 'aa.md' and 'baa.md'. Its solution broke the relative file name usage (e.g. [[aa.md]] was "found" in the inbox). To cover both use case the match needs to be either exact (relative to the vault root), or partial, where the searched file name prefixed with '/' is searched with s-ends-with-p. Fixes issue licht1stein#72.
LA-Toth
force-pushed
the
fix-find-file
branch
from
bcf7e9e
to
786c315
Compare
|
I ran into this same issue. I had two files: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When issue #64 was opened, obsidian--match-files was lazy, only the suffix was checked, so it found for 'aa.md' both 'aa.md' and 'baa.md'. Its solution broke the relative file name usage (e.g. [[aa.md]] was "found" in the inbox).
To cover both use case the match needs to be either exact (relative to the vault root), or partial, where the searched file name prefixed with '/' is searched with s-ends-with-p.
Fixes issue #72.