[WIP] Add Rebasable token to Optimism #58
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) external { | ||
| for (uint256 obIndex = 0; obIndex < observers.length; obIndex++) { | ||
| try ITokenRatePusher(observers[obIndex]).pushTokenRate() {} | ||
| catch (bytes memory lowLevelRevertData) { |
Check warning
Code scanning / Slither
Uninitialized local variables Medium
contracts/lido/TokenRateNotifier.sol
Outdated
| function observersLength() public view returns (uint256) { | ||
| return observers.length; | ||
| } |
Check warning
Code scanning / Slither
Public function that could be declared external Warning
Add ERC-2612/EIP-1271 permit to rebasable token
There was a problem hiding this comment.
Let's add a note about deployment behind proxies for this and other relevant contracts
It would be great to have it as a part of the spec
contracts/token/ERC20Rebasable.sol
Outdated
| WRAPPED_TOKEN = IERC20(wrappedToken_); | ||
| TOKEN_RATE_ORACLE = ITokenRateOracle(tokenRateOracle_); | ||
| BRIDGE = bridge_; | ||
| } |
There was a problem hiding this comment.
__disable_Initializers() or whatever
There was a problem hiding this comment.
https://forum.openzeppelin.com/t/what-does-disableinitializers-function-mean/28730
relevant mostly not for this contract, but for others (bridges, might be applicable for TokenRateOracle, whatever)
…tests, fix comments
WHAT
Implement a new rebasable token on Optimism
HOW
Detailed schemes and explanation you can find here https://hackmd.io/@lido/ryKP1ssm6
TODO