WIP: mgr/devicehealth: added life_expectancy_response() #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
git rebase HEAD^ --onto liewegas/wip-devicehealth |
liewegas
reviewed
Jun 11, 2018
| ] | ||
| DEFAULTS = { | ||
| 'active': True, | ||
| 'scrape_frequency': '86400', | ||
| 'retention_period': '86400*14', | ||
| 'pool_name': 'device_health_metrics', | ||
| 'mark_out_threshold': 86400*14, # TODO: change back to string |
liewegas
force-pushed
the
wip-devicehealth
branch
2 times, most recently
from
5b0b1db to
c138c85
Compare
liewegas
reviewed
Jun 11, 2018
| 'MGR_DEVICE_HEALTH': { | ||
| 'severity': 'warning', | ||
| 'summary': 'Imminent failure was detected on some devices.' | ||
| ' Run "ceph health detail".', |
liewegas
reviewed
Jun 11, 2018
| self.set_health_checks({ | ||
| 'MGR_DEVICE_HEALTH': { | ||
| 'severity': 'warning', | ||
| 'summary': 'Imminent failure was detected on some devices.' |
There was a problem hiding this comment.
Imminent failure anticipated for device(s)
liewegas
reviewed
Jun 11, 2018
| r, outb, outs = result.wait() | ||
| # TODO what else should we do in case marking out failed? | ||
| if r != 0: | ||
| self.log.error('Error: Could not mark OSD %s out. r: [%s], outb: [%s], outs: [%s]' % (osd_ids, r, outb, outs)) |
There was a problem hiding this comment.
log a warning, but this isn't a critical error (ceph osd out will enver really fail.. and if it does, we'll do it again the next time)
Let's avoid "SMART" since it's misleading (it refers specifically to ATA). Signed-off-by: Sage Weil <[email protected]>
Signed-off-by: Sage Weil <[email protected]>
This is more useful than the current local device name. Clean up some formatting. Signed-off-by: Sage Weil <[email protected]>
This is slightly different than the usual pattern because it is parameterized. I want to avoid fetching *all* devices if we don't need it. Signed-off-by: Sage Weil <[email protected]>
Signed-off-by: Sage Weil <[email protected]>
- command to fetch smart info - command to scrape a device and store the metrics - command to scrape all devices (and store) - command to dump stored metrics - purging of old metrics This is based on code originally written by Yaarit. Signed-off-by: Yaarit Hatuka [email protected] Signed-off-by: Sage Weil <[email protected]>
… stored Signed-off-by: Sage Weil <[email protected]>
Signed-off-by: Sage Weil <[email protected]>
liewegas
force-pushed
the
wip-devicehealth
branch
from
9053199 to
5a44d4f
Compare
- if mark_out_threshold is met we write to log.warn instead of raising a health warning. - check that OSD is 'in' before calling mark_out(). - raise a health warning in case OSD is marked 'out' but still has PGs attached to it. - cast thresholds default values to string. - add SCSI multipath support to health warning message. - change health warning message. Signed-off-by: Yaarit Hatuka [email protected]
Signed-off-by: Yaarit Hatuka [email protected]
liewegas
force-pushed
the
wip-devicehealth
branch
6 times, most recently
from
9c4880f to
dd6ad72
Compare
liewegas
pushed a commit
that referenced
this pull request
Nov 5, 2021
sub-menu component, --shadow-black custom property, icons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.