Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPD 41359 (The installer popup should present JDK21 as an option if found) #393

Merged

Conversation

drewbrokke
Copy link
Member

  • LPD-41359 installers: adds JDK 21 in autodetect installer components
  • LPD-41359 installers: renames variable to include JDK 21
  • LPD-41359 installers: properly sets the variable when JDK 21 is selected
  • LPD-41359 installers: SF: removes trailing whitespace
  • LPD-41359 installers: refactor installer file to be more readable
  • LPD-41359 installers: simplify proxy setup
  • LPD-41359 installers: uses findFile to find zip file instead of conditionals
  • LPD-41359 installers: removes unused statements left over from when token support was removed
  • LPD-41359 installers: consolidate autodetect-java logic to a single file

Copy link
Member

@gamerson gamerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@drewbrokke drewbrokke changed the title LPD 41359 TASK v1 select JKD21 LPD 41359 (The installer popup should present JDK21 as an option if found) Dec 4, 2024
@drewbrokke drewbrokke merged commit b417509 into liferay:master Dec 4, 2024
2 checks passed
@drewbrokke drewbrokke deleted the LPD-41359-TASK-v1-select-JKD21 branch December 5, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants