Consider missing signature equivalent to non-generic one #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since for those it should be sufficient to check the descriptor anyway, and the Scala compiler started emitting more signatures between 3.1.1 and 3.1.2 (from the functional tests it seems there were already a couple of cases where Scala3 produced more signatures than expected, we now ignore those as well) References lightbend-labs#693
raboof
force-pushed
the
consider-missing-signature-equivalent-to-nongeneric
branch
from
ab786c4 to
6e017db
Compare
ah, scala3 previously already generated 'unexpected' signatures in some cases already (scala/scala3#10837), these problems are also filtered out with this approach. That seems OK. |
dwijnand
approved these changes
Apr 29, 2022
|
Can we get a new release containing this fix? |
Dale's on vacation at the moment. Though little of his attention has been going to MiMa lately I note that this repo isn't on sbt-ci-release. Releases would be easier to roll if it were. I've opened #718 – perhaps a volunteer would like to tackle it |
|
1.1.1 is published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since for those it should be sufficient to check the descriptor anyway,
and the Scala compiler started emitting more signatures between
3.1.1 and 3.1.2
Fixes #693