Protobuf scala span creation #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
aludwiko
reviewed
Apr 2, 2024
samples/scala-protobuf-tracing/src/main/scala/com/example/ControllerAction.scala
Outdated
Show resolved
Hide resolved
octonato
reviewed
Apr 2, 2024
samples/scala-protobuf-tracing/src/main/scala/com/example/ControllerAction.scala
Outdated
Show resolved
Hide resolved
...a-sdk-protobuf-testkit/src/main/scala/kalix/scalasdk/testkit/impl/TestKitActionContext.scala
Outdated
Show resolved
Hide resolved
franciscolopezsancho
force-pushed
the
protobuf_scala_span_creation
branch
from
186a8ad to
2dc6ce4
Compare
octonato
reviewed
Apr 5, 2024
sdk/java-sdk-protobuf/src/main/scala/kalix/javasdk/impl/telemetry/Telemetry.scala
Outdated
Show resolved
Hide resolved
sdk/java-sdk-protobuf/src/main/scala/kalix/javasdk/impl/telemetry/Telemetry.scala
Show resolved
Hide resolved
octonato
approved these changes
Apr 5, 2024
samples/java-protobuf-tracing/src/main/java/com/example/ControllerAction.java
Show resolved
Hide resolved
sdk/java-sdk-protobuf/src/main/java/kalix/javasdk/action/ActionCreationContext.java
Show resolved
Hide resolved
sdk/java-sdk-protobuf/src/main/java/kalix/javasdk/action/ActionCreationContext.java
Show resolved
Hide resolved
sdk/java-sdk-protobuf/src/main/scala/kalix/javasdk/impl/telemetry/Telemetry.scala
Outdated
Show resolved
Hide resolved
sdk/java-sdk-protobuf/src/main/scala/kalix/javasdk/impl/telemetry/Telemetry.scala
Show resolved
Hide resolved
sdk/java-sdk-protobuf/src/main/scala/kalix/javasdk/impl/telemetry/Telemetry.scala
Show resolved
Hide resolved
Co-authored-by: Renato Cavalcanti <[email protected]>
Co-authored-by: Renato Cavalcanti <[email protected]>
This was referenced Apr 8, 2024
…nCreationContext.java Co-authored-by: Renato Cavalcanti <[email protected]>
octonato
added a commit
that referenced
this pull request
Apr 10, 2024
* feat: showcasing how to create spans (#2051) * feat: showcasing how to create spans * bug: using nonexisting (and deprecated) docker-compose (#2071) * chore: aligning .env and docker-compose.yml (#2070) * Protobuf scala span creation (#2069) * Added tracing context in Scala SDK and using sttp in the Scala sample * simpler sync example * added async calling endpoint * using core sttp and some cleaning * refactoring * added readme * removing sync * implementing interface for ScalaActionContextAdapter * Cleaned and created docs * Clean up scala-protobuf-traicing sample and adding NoOps tracer for a better DX * docs and new implementation for the java-protobuf-tracing example * avoid validating local urls and validate back * Update docs/src/modules/java-protobuf/pages/actions.adoc Co-authored-by: Renato Cavalcanti <[email protected]> * Update samples/scala-protobuf-tracing/project/plugins.sbt Co-authored-by: Renato Cavalcanti <[email protected]> * Update sdk/java-sdk-protobuf/src/main/java/kalix/javasdk/action/ActionCreationContext.java Co-authored-by: Renato Cavalcanti <[email protected]> * addressing comments * simplifying request/response types --------- Co-authored-by: Renato Cavalcanti <[email protected]> * bump: Kalix Runtime to 1.1.34 (#2060) * feat: ComponentClient tracing (#2063) * feat: ComponentClient tracing * feat: component to component tracing spring * move KalixClient to impl package * formatting * re-added full imports * Apply suggestions from code review Co-authored-by: Eduardo Pinto <[email protected]> * Update sdk/java-sdk-spring/src/test/java/kalix/javasdk/client/ComponentClientTest.java Co-authored-by: Eduardo Pinto <[email protected]> * renamed method and added extra comments * remove possibility to inject KalixClient * remove direct dependency on KalixClient * use FQCN when failing wiring --------- Co-authored-by: Francisco Lopez-Sancho <[email protected]> Co-authored-by: Eduardo Pinto <[email protected]> * Update LICENSE to BSL (#2054) * Update LICENSE to BSL * Date reminder --------- Co-authored-by: Enno Runne <[email protected]> * chore: bump akka libs to latest (#2067) * chore: bump akka libs to latest * remove akka-http2-support deps * used scalaPb instead of akka-grpc * add akka resolvers to scala samples * add akka resolvers to mvn samples and archetypes * align protoc version * chore: disciplined compiler settings and deprecation removal (#2072) * chore: remove warnings and deprecated APIs * remove EntityKey, EntityType and GenerateEntityKey * remove KalixTestKit.getTopic * remove KalixTestKit.getGrpcClientSettings * remove withPassivationStrategy * remove Auto-application to () * remove usage of Akka deprecated APIs * fixing scaladoc links * silence warnings from generated code * fix GenerateMojo call * remove unused imports * fix link to OutgoingMessagesImpl#DefaultTimeout * BSL license in project settings (#2076) * fix compilation and headers * align protoc version * add akka resolvers to tracing samples --------- Co-authored-by: Francisco Lopez-Sancho <[email protected]> Co-authored-by: Kalix Bot <[email protected]> Co-authored-by: Eduardo Pinto <[email protected]> Co-authored-by: Justin Pihony <[email protected]> Co-authored-by: Enno Runne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding example on how to create spans in the scala-protobuf
Depends on #2051 . Specifically because
DevModeSettingsto pass the params to the user function needed to push traces to jaeger in a local environment.