add smaug plugin #644
Merged
add smaug plugin #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisguida
force-pushed
the
smaug
branch
9 times, most recently
from
8e3d8a5 to
110f380
Compare
This is to avoid the case where a Rust plugin has a pip requirements file or a pyproject.toml file for testing purposes, but we still want to run the generic tests/setup.sh script rather than attempting to build a Python plugin.
|
Okay, the CI is passing! I needed to update the CI code in order to handle the case where a Rust plugin has a Poetry project for testing purposes... obviously we still want to run the generic setup.sh in that case! Another note: It's expected that smaug won't work on CLN 24.05 and before, since the PR allowing smaug to work was not released until 24.08. |
|
ACK 1200f60 |
|
Hey @cdecker @vincenzopalazzo could one of you merge this please? Would rather not self-merge my own plugin :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin sends bkpr-compatible events to the bkpr plugin for external on-chain wallet movements. This allows bkpr to maintain a full picture of a merchant's bitcoin inflows and outflows, vastly improving bitcoin accounting and financial analysis.