-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding instrumentation specific settings and adjust whitespacing #71
Merged
jaronoff97
merged 6 commits into
lightstep:main
from
rivToadd:auto-instrumentation-env-variables
Feb 26, 2024
Merged
feat: Adding instrumentation specific settings and adjust whitespacing #71
jaronoff97
merged 6 commits into
lightstep:main
from
rivToadd:auto-instrumentation-env-variables
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g for instrumentation
michael132
reviewed
Feb 23, 2024
rivToadd
force-pushed
the
auto-instrumentation-env-variables
branch
from
February 23, 2024 20:58
696f431
to
d1cc8e2
Compare
rivToadd
force-pushed
the
auto-instrumentation-env-variables
branch
from
February 23, 2024 20:59
d1cc8e2
to
5164fa3
Compare
jaronoff97
reviewed
Feb 26, 2024
{{- end }} | ||
{{- range $language, $settings := .Values.autoinstrumentation.languageSettings }} | ||
{{$language}}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
{{$language}}: | |
{{ $language }}: |
jaronoff97
approved these changes
Feb 26, 2024
jaronoff97
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I want to be able to add auto-instrumentation specific things and not see giant whitespaces when running helm template
How Has This Been Tested?
Running helm template and then applying this on my environment
sample helm template
R/CC: Who should know about this change? Requesting any reviewers in particular?