Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding instrumentation specific settings and adjust whitespacing #71

Merged

Conversation

rivToadd
Copy link
Contributor

@rivToadd rivToadd commented Feb 23, 2024

Description

I want to be able to add auto-instrumentation specific things and not see giant whitespaces when running helm template

How Has This Been Tested?

Running helm template and then applying this on my environment

sample helm template

apiVersion: opentelemetry.io/v1alpha1
kind: Instrumentation
metadata:
  name: kube-otel-stack-instrumentation
spec:
  exporter:
    endpoint: http://kube-otel-stack-traces-collector.default:4317
  propagators:
    - tracecontext
    - baggage
    - b3
  sampler:
    argument: "0.25"
    type: parentbased_traceidratio
  env:
    - name: OTEL_LOG_LEVEL
      value: DEBUG
    - name: OTEL_EXPORTER_OTLP_ENDPOINT
      value: traces:4317
  python:
    env:
      - name: OTEL_PYTHON_LOGGING_AUTO_INSTRUMENTATION_ENABLED
        value: "true"
      - name: OTEL_TRACES_EXPORTER
        value: otlp

R/CC: Who should know about this change? Requesting any reviewers in particular?

@rivToadd rivToadd marked this pull request as draft February 23, 2024 18:50
@rivToadd rivToadd marked this pull request as ready for review February 23, 2024 18:56
@rivToadd rivToadd force-pushed the auto-instrumentation-env-variables branch from 696f431 to d1cc8e2 Compare February 23, 2024 20:58
@rivToadd rivToadd force-pushed the auto-instrumentation-env-variables branch from d1cc8e2 to 5164fa3 Compare February 23, 2024 20:59
{{- end }}
{{- range $language, $settings := .Values.autoinstrumentation.languageSettings }}
{{$language}}:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{$language}}:
{{ $language }}:

@jaronoff97 jaronoff97 merged commit 11a3c44 into lightstep:main Feb 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants