Add detail on empty attribute key error (#298)

lightstep · Oct 5, 2022 · 00dc01a · 00dc01a
1 parent 3a6bc96
commit 00dc01a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lightstep/sdk/metric/internal/viewstate/base_instrument.go b/lightstep/sdk/metric/internal/viewstate/base_instrument.go
@@ -115,7 +115,7 @@ func (metric *instrumentBase[N, Storage, Auxiliary, Methods]) applyKeysFilter(kv
 		kv := iter.Attribute()
 		if !isValidAttribute(kv) {
 			doevery.TimePeriod(time.Minute, func() {
-				otel.Handle(fmt.Errorf("use of empty attribute key, e.g., with value %q", kv.Value.Emit()))
+				otel.Handle(fmt.Errorf("use of empty attribute key, e.g., metric name %q with value %q", metric.desc.Name, kv.Value.Emit()))
 			})
 			invalidFilter = true
 			break

diff --git a/lightstep/sdk/metric/internal/viewstate/viewstate_test.go b/lightstep/sdk/metric/internal/viewstate/viewstate_test.go
@@ -1724,7 +1724,7 @@ func TestEmptyKeyFilter(t *testing.T) {
 	)
 
 	require.Equal(t, 1, len(*errs))
-	require.Equal(t, "use of empty attribute key, e.g., with value \"1value\"", (*errs)[0].Error())
+	require.Equal(t, "use of empty attribute key, e.g., metric name \"foo\" with value \"1value\"", (*errs)[0].Error())
 }
 
 // TestEmptyKeyFilterAndView ensures no empty keys are used (with a view config).