[2.x] Update minimum versions for optional dependencies and fix DBAL 2.x compat #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbabker
commented
Mar 11, 2024
mbabker
commented
Mar 11, 2024
mbabker
commented
Mar 11, 2024
mbabker
commented
Mar 11, 2024
…cts to prevent installing newer releases with incompatible versions
mbabker
changed the title
|
@alexislefebvre We should be good to go here, only a couple of DBAL 2.x compat issues crept in since the CI wasn't running against that version. |
No problem, thanks for the PR! Here is the new release with these changes: https://github.com/liip/LiipTestFixturesBundle/releases/tag/2.8.1 |
Merged
|
Please check the PR about merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #276
I mostly based this on the output from https://github.com/liip/LiipTestFixturesBundle/actions/runs/8225016225/job/22489537505 (the
--prefer-lowestrun for the last merge on the 2.x branch) and info fromcomposer why(notes inline with the diff).Without getting into a massively complicated CI matrix where all of the optional integrations are stripped out and runs are made with only a single integration installed (i.e. a job where the ORM and MongoDB ODM are removed and only the PHPCR ODM kept, the two ODMs removed and only the ORM kept, etc.), this is the best that can be done for the moment.
3.x will need a similar PR after this one is reviewed and upmerged (sorry for the conflicts this will create 😅)