Update preprocessing.py #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandas groupby call now defaults to `numeric_only=False`. See pandas-dev/pandas#46072. This change breaks `get_filter_stats` call when `data.obs` contains `str` and `category` dtype. It fixes by explicitly calling `median` function with `numeric_only=True`.
yihming
approved these changes
Feb 4, 2025
|
@hoondy Thank you for your contribution! I'll fix the CI part so no worry about check failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas groupby call now defaults to
numeric_only=False. See pandas-dev/pandas#46072. This change breaksget_filter_statscall whendata.obscontainsstrandcategorydtype. It fixes by explicitly callingmedianfunction withnumeric_only=True.