-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TW-1735: can't search matrix id #1784
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Te-Z
requested review from
sherlockvn,
hoangdat,
dab246,
nqhhdev,
hieutbui and
tddang-linagora
as code owners
May 20, 2024 15:56
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1784 |
hoangdat
approved these changes
May 21, 2024
nqhhdev
approved these changes
May 21, 2024
sherlockvn
reviewed
May 21, 2024
should we handle this case: @hoangdat |
Hi @hoangdat @sherlockvn , to handle keyword length and the case with |
Te-Z
force-pushed
the
TW-1735/cant-search-matrix-id
branch
from
May 21, 2024 12:25
c4732b3
to
454d428
Compare
sherlockvn
approved these changes
May 22, 2024
Te-Z
force-pushed
the
TW-1735/cant-search-matrix-id
branch
from
May 22, 2024 16:04
8729417
to
55af7c2
Compare
hoangdat
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #1735
Waiting for this PR to be merged: linagora/matrix-dart-sdk#59
Demo:
Capture.video.du.20-05-2024.17.51.03.webm