Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-1735: can't search matrix id #1784

Merged
merged 3 commits into from
May 23, 2024
Merged

Conversation

Te-Z
Copy link
Contributor

@Te-Z Te-Z commented May 20, 2024

Ticket: #1735

Waiting for this PR to be merged: linagora/matrix-dart-sdk#59

Demo:

Capture.video.du.20-05-2024.17.51.03.webm

Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1784

@sherlockvn
Copy link
Contributor

should we handle this case: @hoangdat
image

@Te-Z
Copy link
Contributor Author

Te-Z commented May 21, 2024

Hi @hoangdat @sherlockvn , to handle keyword length and the case with @@@@@@tom:client.com I updated the isValidMatrixId method from sdk: linagora/matrix-dart-sdk#59
Those cases are handled and tested in unit test

@hoangdat hoangdat merged commit 9055ce0 into main May 23, 2024
7 checks passed
@hoangdat hoangdat deleted the TW-1735/cant-search-matrix-id branch May 23, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants