Tw 1702/hotfix error handling on download

[Te-Z]

Ticket: #1702

NEED MERGE FIRST: linagora/matrix-dart-sdk#61

Done:

• fixed regression on error handling when downloading a file
• refactored a bit the code for better testability
• created tests for mobile
• created tests for web

screen-20240528-190457.mp4

Error handling when there is no connection to the server:

downloadError.webm

[github-actions]

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1814

[sherlockvn]

I tested in IOS, its only show the error in 1/3 cases. wdyt @Te-Z

RPReplay_Final1717490331.2.MP4

[Te-Z]

I tested in IOS, its only show the error in 1/3 cases. wdyt @Te-Z

RPReplay_Final1717490331.2.MP4

Hi @sherlockvn this a problem indeed. I can't reproduce it on my side since I don't have a macbook. But looks like it works on web and android. Can you help me debug it please ? If not maybe we will create a ticket to debug it on iOS

[sherlockvn]

I tested in IOS, its only show the error in 1/3 cases. wdyt @Te-Z
RPReplay_Final1717490331.2.MP4

Hi @sherlockvn this a problem indeed. I can't reproduce it on my side since I don't have a macbook. But looks like it works on web and android. Can you help me debug it please ? If not maybe we will create a ticket to debug it on iOS

i will create another ticket, because im in another ticket right now

[Te-Z]

I tested in IOS, its only show the error in 1/3 cases. wdyt @Te-Z

RPReplay_Final1717490331.2.MP4

@sherlockvn looks like it's fixed after rebase. I'm not able to reproduce it. Could you try again ?

[Te-Z]

@sherlockvn actually what you have is the normal behavior of download manager: if connection is lost and not error is thrown, the file stays in the queue to be able to continue download

[sherlockvn]

@sherlockvn actually what you have is the normal behavior of download manager: if connection is lost and not error is thrown, the file stays in the queue to be able to continue download

it will not continue downloading.

RPReplay_Final1721622320.MP4

[Te-Z]

@KhaledNjim could you please provide a demo of the fix you've done ?

[KhaledNjim]

@KhaledNjim could you please provide a demo of the fix you've done ?

Added in the pr description

[Te-Z]

@sherlockvn it should be good now. Could you review it again please ?

[sherlockvn]

i tested and i worked well in iOS.

[sherlockvn]

please rebase