TW-746: apply download images/videos in mobile #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlockvn
requested review from
hoangdat,
dab246,
nqhhdev,
imGok and
drminh2807
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/881 |
drminh2807
reviewed
Nov 1, 2023
hoangdat
reviewed
Nov 1, 2023
| // FIXME: change to false after https://github.com/linagora/twake-on-matrix/issues/746 | ||
| getThumbnail: true, | ||
| future: controller.widget.event.getFileInfo( | ||
| getThumbnail: false, |
There was a problem hiding this comment.
i think when open image in full screen, we should download the root file not thumbnail one
hoangdat
reviewed
Nov 1, 2023
drminh2807
reviewed
Nov 2, 2023
sherlockvn
force-pushed
the
TW-746/download-image-video-using-stream
branch
from
7b3e0a8
to
292b080
Compare
drminh2807
reviewed
Nov 2, 2023
imGok
reviewed
Nov 2, 2023
| @@ -505,4 +505,8 @@ extension SendFileExtension on Room { | |||
| Future<Size> _calculateImageBytesDimension(Uint8List bytes) { | |||
| return Image.memory(bytes).calculateImageDimension(); | |||
| } | |||
|
|
|||
| bool isRoomEncrypted() { | |||
There was a problem hiding this comment.
could you move it to room extension please ? Would be useful for encrypted icon for example
There was a problem hiding this comment.
it's already in the room extension
There was a problem hiding this comment.
Isn't it in Send file extension
There was a problem hiding this comment.
year and on Room :))
imGok
reviewed
Nov 2, 2023
imGok
reviewed
Nov 2, 2023
imGok
reviewed
Nov 2, 2023
lib/utils/string_extension.dart
Outdated
| @@ -297,7 +297,7 @@ extension StringCasingExtension on String { | |||
| if (length < maxCharacters) return this; | |||
| return substring(0, maxCharacters); | |||
| } | |||
|
|
|||
imGok
reviewed
Nov 2, 2023
lib/widgets/mxc_image.dart
Outdated
Comment on lines
274
to
307
| child: filePath != null && filePath!.isNotEmpty | ||
| ? Image.file( | ||
| File(filePath!), | ||
| width: widget.width, | ||
| height: widget.height, | ||
| cacheWidth: needResize ? widget.width?.toInt() : null, | ||
| cacheHeight: needResize ? widget.height?.toInt() : null, | ||
| fit: widget.fit, | ||
| filterQuality: FilterQuality.medium, | ||
| errorBuilder: (context, __, ___) { | ||
| _isCached = false; | ||
| filePath = null; | ||
| WidgetsBinding.instance.addPostFrameCallback(_tryLoad); | ||
| return placeholder(context); | ||
| }, | ||
| ) | ||
| : data != null | ||
| ? Image.memory( | ||
| data, | ||
| width: widget.width, | ||
| height: widget.height, | ||
| cacheWidth: needResize ? widget.width?.toInt() : null, | ||
| cacheHeight: needResize ? widget.height?.toInt() : null, | ||
| fit: widget.fit, | ||
| filterQuality: FilterQuality.medium, | ||
| errorBuilder: (context, __, ___) { | ||
| _isCached = false; | ||
| _imageData = null; | ||
| WidgetsBinding.instance | ||
| .addPostFrameCallback(_tryLoad); | ||
| return placeholder(context); | ||
| }, | ||
| ) | ||
| : const SizedBox.shrink(), |
There was a problem hiding this comment.
can you write methods to simplify the comprehension ? nested ternary conditions are hard to read
drminh2807
approved these changes
Nov 3, 2023
sherlockvn
force-pushed
the
TW-746/download-image-video-using-stream
branch
from
0693782
to
967a07e
Compare
hoangdat
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blockers:
Demo 1: compare memory usage when user scroll through a lot of images
Screen.Recording.2023-10-31.at.14.43.47.mov
Screen.Recording.2023-10-31.at.14.39.47.mov
Demo 2: compare memory usage when download a video
new.mov
-After:
Screen.Recording.2023-10-31.at.17.30.33.mov
Demo image and video in web and mobile in unencrypted chat
new_demo.mov