Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quality of life improvements for using benchmarks #257

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Quality of life improvements for using benchmarks #257

merged 1 commit into from
Aug 9, 2023

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Related to issue #79

Small updates to recent addition of ASV benchmarking suite. This is based on my experiences adding benchmarks in astronomy-commons/hats#124

Checklist

  • This PR is meant for the lincc-frameworks/python-project-template repo and not a downstream one instead.
  • This change is linked to an open issue
  • This change includes integration testing, or is small enough to be covered by existing tests

drewoldag
drewoldag approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@delucchi-cmu delucchi-cmu merged commit abdd644 into main Aug 9, 2023
15 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/benchmarks branch September 8, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewoldag drewoldag drewoldag approved these changes

@camposandro camposandro Awaiting requested review from camposandro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delucchi-cmu @drewoldag