Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install sphinx from docs/requirements. #436

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Install sphinx from docs/requirements. #436

merged 2 commits into from
Feb 26, 2024

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Feb 26, 2024

Change Description

Closes #431 .

Adds lines in setup scripts to install all dependencies in docs/requirements, so we're not maintaining the list of docs requirements in two places. Removes those dependencies from pyproject.toml, and also alpha-sorts the current dependencies list (because it irks me that a freshly-minted project is unsorted).

Checklist

  • This PR is meant for the lincc-frameworks/python-project-template repo and not a downstream one instead.
  • This change is linked to an open issue
  • This change includes integration testing, or is small enough to be covered by existing tests

Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

python-project-template/.setup_dev.sh Outdated Show resolved Hide resolved
python-project-template/.initialize_new_project.sh Outdated Show resolved Hide resolved
Co-authored-by: Konstantin Malanchev <[email protected]>
@delucchi-cmu delucchi-cmu merged commit 08135b0 into main Feb 26, 2024
5 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/431/sphinx branch February 26, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sphinx_copybutton is missed from .[dev]
2 participants