Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move jupyter requirement. #441

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Move jupyter requirement. #441

merged 1 commit into from
Mar 8, 2024

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Mar 8, 2024 •
edited
Loading

Change Description

Closes #440. Moves jupyter dependency back to .dev.

Checklist

  • This PR is meant for the lincc-frameworks/python-project-template repo and not a downstream one instead.
  • This change is linked to an open issue
  • This change includes integration testing, or is small enough to be covered by existing tests

drewoldag
drewoldag approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Seems like we should invest a little time into writing a test that can run the pre-commit hooks :(

@delucchi-cmu delucchi-cmu merged commit 8226300 into main Mar 8, 2024
5 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/440/jupyter branch March 8, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewoldag drewoldag drewoldag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jupyter dependency needed for pre-commit
2 participants
@delucchi-cmu @drewoldag