Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asv failures and upgrade its default version #482

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

camposandro
Copy link
Contributor

@camposandro camposandro commented Sep 30, 2024

This pull request resolves the Python environment issues experienced in tdastro and nested-dask. For reference, these changes were applied in lincc-frameworks/nested-dask#58 and the workflows are passing again. Closes #477.

What changed

I removed the unnecessary caching of the Python environment and I upgraded the default version to asv 0.6.4 (its latest). The files were also formatted more consistently.

Checklist

  • This PR is meant for the lincc-frameworks/python-project-template repo and not a downstream one instead.
  • This change is linked to an open issue
  • This change includes integration testing, or is small enough to be covered by existing tests

@camposandro camposandro self-assigned this Sep 30, 2024
Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very reasonable to me, thank you!

@camposandro camposandro merged commit 0948a46 into main Sep 30, 2024
5 checks passed
@camposandro camposandro deleted the issue/477/fix-asv-failures branch September 30, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASV is failing on github actions
2 participants