Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to benchmarks #485

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Add type hints to benchmarks #485

merged 1 commit into from
Oct 1, 2024

Conversation

smcguire-cmu
Copy link
Contributor

Change Description

Adds type hints to the example_benchmarks file. Fixes #457

Checklist

  • This PR is meant for the lincc-frameworks/python-project-template repo and not a downstream one instead.
  • This change is linked to an open issue
  • This change includes integration testing, or is small enough to be covered by existing tests

@smcguire-cmu smcguire-cmu merged commit bc8bdee into main Oct 1, 2024
5 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/fix-benchmarks-typing branch October 1, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camposandro camposandro camposandro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: .initialize_new_project.sh fails with strict mypy when including benchmark files
2 participants
@smcguire-cmu @camposandro