Skip to content

Commit

Permalink
fix: minor bugs in dashboard page (#132)
Browse files Browse the repository at this point in the history
fix: minor bugs
  • Loading branch information
chiol authored Jan 15, 2024
1 parent 2006bb8 commit 1bd7292
Show file tree
Hide file tree
Showing 8 changed files with 20 additions and 20 deletions.
6 changes: 3 additions & 3 deletions apps/web/public/locales/en/common.json
Original file line number Diff line number Diff line change
Expand Up @@ -390,11 +390,11 @@
}
},
"chart": {
"total-feedback-trend": {
"feedback-trend": {
"title": "Feedback Trend",
"description": "Display the trend of feedback creation over a specific period of time."
},
"total-issue-trend": {
"issue-trend": {
"title": "Issue Trend",
"description": "Display the trend of Issue creation over a specific period of time."
},
Expand All @@ -406,7 +406,7 @@
"title": "Top Issue",
"description": "Display the top issues with a large number of count."
},
"issue-trend": {
"issue-comparison": {
"title": "Issue comparison",
"description": "Compare and display the trend of feedback creation for selected issues."
}
Expand Down
9 changes: 4 additions & 5 deletions apps/web/public/locales/ja/common.json
Original file line number Diff line number Diff line change
Expand Up @@ -390,14 +390,13 @@
}
},
"chart": {
"total-feedback-trend": {
"feedback-trend": {
"title": "フィードバック生成推移",
"description": "特定の期間のフィードバック生成の推移を示します。"
},
"total-issue-trend": {
"issue-trend": {
"title": "イシュー生成推移",
"description": "特定期間のイシュー作成推移を示します。",
"issue-count": "イシュー生成数"
"description": "特定期間のイシュー作成推移を示します。"
},
"issue-status-count": {
"title": "イシュー現況",
Expand All @@ -407,7 +406,7 @@
"title": "上位イシュー",
"description": "フィードバック数が多い上位イシューを表示します。"
},
"issue-trend": {
"issue-comparison": {
"title": "イシュー比較",
"description": "選択したイシューのフィードバック生成推移を比較して表示します。"
}
Expand Down
6 changes: 3 additions & 3 deletions apps/web/public/locales/ko/common.json
Original file line number Diff line number Diff line change
Expand Up @@ -390,11 +390,11 @@
}
},
"chart": {
"total-feedback-trend": {
"feedback-trend": {
"title": "피드백 생성 추이",
"description": "특정 기간의 피드백 생성 추이를 보여줍니다."
},
"total-issue-trend": {
"issue-trend": {
"title": "이슈 생성 추이",
"description": "특정 기간의 이슈 생성 추이를 보여줍니다."
},
Expand All @@ -406,7 +406,7 @@
"title": "상위 이슈",
"description": "피드백 개수가 많은 상위 이슈를 보여줍니다."
},
"issue-trend": {
"issue-comparison": {
"title": "이슈 비교",
"description": "선택한 이슈의 피드백 생성 추이를 비교해서 보여줍니다."
}
Expand Down
1 change: 1 addition & 0 deletions apps/web/src/components/charts/LineChart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ const LineChart: React.FC<IProps> = ({
className="font-10-regular text-secondary"
tickSize={15}
tickLine={false}
interval="equidistantPreserveStart"
/>
<YAxis
tickFormatter={(v) => v.toLocaleString()}
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/layouts/Header/LocaleSelectBox.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const LocaleSelectBox: React.FC<IProps> = () => {
</>
)}
</Listbox.Button>
<Listbox.Options className="bg-primary absolute z-10 mt-1 w-full rounded border">
<Listbox.Options className="bg-primary absolute z-10 mt-1 w-full overflow-hidden rounded border">
{router.locales
?.filter((v) => v !== 'default')
.map((v) => (
Expand Down
4 changes: 2 additions & 2 deletions apps/web/src/containers/dashboard/FeedbackLineChart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ const FeedbackLineChart: React.FC<IFeedbackLineChartProps> = (props) => {

return (
<SimpleLineChart
title={t('chart.total-feedback-trend.title')}
description={`${t('chart.total-feedback-trend.description')} (${dayjs(
title={t('chart.feedback-trend.title')}
description={`${t('chart.feedback-trend.description')} (${dayjs(
from,
).format('YYYY/MM/DD')} - ${dayjs(to).format('YYYY/MM/DD')})`}
height={400}
Expand Down
4 changes: 2 additions & 2 deletions apps/web/src/containers/dashboard/IssueFeedbackLineChart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@ const IssueFeedbackLineChart: React.FC<IProps> = ({ from, projectId, to }) => {

return (
<SimpleLineChart
title={t('chart.total-issue-trend.title')}
description={`${t('chart.total-issue-trend.description')} (${dayjs(
title={t('chart.issue-comparison.title')}
description={`${t('chart.issue-comparison.description')} (${dayjs(
from,
).format('YYYY/MM/DD')} - ${dayjs(to).format('YYYY/MM/DD')})`}
height={400}
Expand Down
8 changes: 4 additions & 4 deletions apps/web/src/containers/dashboard/IssueLineChart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ const IssueLineChart: React.FC<IProps> = ({ from, projectId, to }) => {

return (
<SimpleLineChart
title={t('chart.total-issue-trend.title')}
description={`${t('chart.total-issue-trend.description')} (${dayjs(
from,
).format('YYYY/MM/DD')} - ${dayjs(to).format('YYYY/MM/DD')})`}
title={t('chart.issue-trend.title')}
description={`${t('chart.issue-trend.description')} (${dayjs(from).format(
'YYYY/MM/DD',
)} - ${dayjs(to).format('YYYY/MM/DD')})`}
height={400}
data={chartData}
dataKeys={dataKeys}
Expand Down

0 comments on commit 1bd7292

Please sign in to comment.