fix: field order (#71)

line · Oct 30, 2023 · ee6b6d9 · ee6b6d9
1 parent 7d57fd8
commit ee6b6d9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 23 deletions.
diff --git a/apps/api/src/domains/channel/field/field.mysql.service.ts b/apps/api/src/domains/channel/field/field.mysql.service.ts
@@ -101,7 +101,6 @@ export class FieldMySQLService {
     this.checkReservedFieldKey(fields);
 
     const fieldsToCreate: CreateFieldDto[] = [
-      ...fields,
       {
         name: 'ID',
         key: 'id',
@@ -134,6 +133,7 @@ export class FieldMySQLService {
         status: FieldStatusEnum.ACTIVE,
         description: '',
       },
+      ...fields,
     ];
 
     const fieldEntities = [];
@@ -158,7 +158,7 @@ export class FieldMySQLService {
     return await this.repository.find({
       where: { channel: { id: channelId } },
       relations: { options: true },
-      order: { createdAt: 'DESC' },
+      order: { createdAt: 'ASC' },
     });
   }
 

diff --git a/apps/api/src/domains/feedback/feedback.service.ts b/apps/api/src/domains/feedback/feedback.service.ts
@@ -162,27 +162,10 @@ export class FeedbackService {
     });
     const worksheet = workbook.addWorksheet('Sheet 1');
 
-    const headerOrderForType = ['DEFAULT', 'API', 'ADMIN'];
-    const headers = fields
-      .sort((a, b) => {
-        const typeA = headerOrderForType.indexOf(a.type);
-        const typeB = headerOrderForType.indexOf(b.type);
-
-        if (typeA !== typeB) return typeA - typeB;
-
-        if (a.type === 'DEFAULT' && b.type === 'DEFAULT') {
-          const nameOrder = ['ID', 'Created', 'Updated', 'Issue'];
-          const nameA = nameOrder.indexOf(a.name);
-          const nameB = nameOrder.indexOf(b.name);
-          return nameA - nameB;
-        }
-
-        return 0;
-      })
-      .map((field) => ({
-        header: field.name,
-        key: field.name,
-      }));
+    const headers = fields.map((field) => ({
+      header: field.name,
+      key: field.name,
+    }));
     worksheet.columns = headers;
 
     const pageSize = 1000;