Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate XdsEndpointGroup to client.endpoint (xDS-endpoint pt 2) #5502

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

jrhee17
Copy link
Contributor

@jrhee17 jrhee17 commented Mar 13, 2024

Motivation:

More classes will be added related to client endpoint, so I propose that we move XdsEndpointGroup from the package com.linecorp.armeria.xds to com.linecorp.armeria.xds.client.endpoint.

Although this PR is mostly refactoring, a new API EndpointGroup#of(ClusterSnapshot) is added since ConfigSourceClient uses GrpcService to decide on the endpoint which will be used.

POC: #5450

Modifications:

  • Move XdsEndpointGroup, XdsConstants to com.linecorp.armeria.xds.client.endpoint
  • Introduce a new API EndpointGroup#of(ClusterSnapshot)
  • Introduce XdsEndpointUtil and move client.endpoint related utility methods from XdsConverterUtil

Result:

  • Preparation for adding new features to XdsEndpointGroup is done

@github-actions github-actions bot requested review from ikhoon, minwoox and trustin March 13, 2024 15:27
@jrhee17 jrhee17 added this to the 1.28.0 milestone Mar 14, 2024
@jrhee17 jrhee17 marked this pull request as ready for review March 14, 2024 13:06
Copy link
Contributor

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@minwoox
Copy link
Contributor

minwoox commented Mar 22, 2024

Let me merge this and #5501 so that @jrhee17 can continue his work in #5503.

@minwoox minwoox merged commit 4dd8c84 into line:main Mar 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants