-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce BraveRpcService
#6115
Open
jrhee17
wants to merge
3
commits into
line:main
Choose a base branch
from
jrhee17:feat/brave-rpc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c0572c
to
c53cb0a
Compare
73dca92
to
7f89976
Compare
ikhoon
reviewed
Feb 24, 2025
* Decorates an {@link RpcService} to trace inbound {@link RpcRequest}s using | ||
* <a href="https://github.com/openzipkin/brave">Brave</a>. | ||
*/ | ||
public final class BraveRpcService extends SimpleDecoratingRpcService { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question) Is it possible to share the common logic with BraveService
by adding AbstractBraveService
and extending it, as you did in AbstractMetricCollectingClient
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The motivation for this PR is better described in #6084
The changeset in this PR attempts to:
ArmeriaHttpServerParser
andArmeriaRpcServerParser
BraveService
orBraveRpcService
. This can provide more flexibility on whether to use onlyBraveService
, onlyBraveRpcService
, or bothBraveService
andBraveRpcService
BraveRpcService
which allows users to perform sampling or request/response parsing based onRpcRequest
Modifications:
BraveRpcService
. By default, armeria-specific tags/annotations recorded byBraveRpcService
is the same asBraveService
ArmeriaHttpServerParser
andArmeriaRpcServerParser
to allow users to easily construct aRpcTracing
orHttpTracing
Result:
RpcRequest
,RpcResponse
to apply sampling/tags/annotations