-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the notion of a default SessionProtocol
#6128
Open
jrhee17
wants to merge
5
commits into
line:main
Choose a base branch
from
jrhee17:feat/default-protocol
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6128 +/- ##
============================================
- Coverage 74.44% 74.40% -0.04%
- Complexity 22059 22219 +160
============================================
Files 1942 1960 +18
Lines 82033 82333 +300
Branches 10736 10740 +4
============================================
+ Hits 61070 61262 +192
- Misses 15854 15948 +94
- Partials 5109 5123 +14 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It has been suggested that
SessionProtocol.UNDEFINED
be avoided at #6060 (comment), and a defaultSessionProtocol
for clients is introduced.A client can now be created without the user explicitly providing a
SessionProtocol
. By defaultSessionProtocol.HTTP
will be used. For clients that are created with a String, users will be able to use the defaultSessionProtocol
via scheme relative URIs as defined in the following rfc.One point to note is that
RequestTarget
may be parsed different depending on whether the input is a path, or a uri.In the context of a path,
//my-path
is a completely valid path whereas in the context of a URI,//my-path
will be a uri with authoritymy-path
.In order to address this,
DefaultRequestTarget#forClientPath
has been introduced.Possibly breaking behavior is that requests cannot be made using a path starting with
//
.Modifications:
SessionProtocol
as defined bySessionProtocolUtil#defaultSessionProtocol
.RequestTarget#forClient
RequestTarget#forClientPath
and modified existing callers to use the new API when applicableResult:
SessionProtocol