Cache revision tree bytes for history call #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minwoox
changed the title
|
ikhoon
reviewed
Feb 11, 2025
| try { | ||
| return delegate.open(objectId0, typeHint); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("failed to open an object: " + objectId0, e); |
There was a problem hiding this comment.
nit:
Suggested change
| throw new RuntimeException("failed to open an object: " + objectId0, e); | |
| throw new UncheckedIOException("failed to open an object: " + objectId0, e); |
Comment on lines
37
to
38
| private static final Logger logger = LoggerFactory.getLogger(CachingTreeObjectReader.class); | ||
|
|
There was a problem hiding this comment.
nit: unused.
Suggested change
| private static final Logger logger = LoggerFactory.getLogger(CachingTreeObjectReader.class); |
...om/linecorp/centraldogma/server/internal/storage/repository/git/CachingTreeObjectReader.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1097 +/- ##
============================================
- Coverage 70.29% 70.07% -0.22%
- Complexity 4284 4388 +104
============================================
Files 427 443 +16
Lines 17258 17700 +442
Branches 1915 1946 +31
============================================
+ Hits 12131 12404 +273
- Misses 4077 4245 +168
- Partials 1050 1051 +1 ☔ View full report in Codecov by Sentry. |
jrhee17
approved these changes
Feb 12, 2025
|
Thanks for reviewing. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The history call is resource-intensive, consuming significant CPU and memory when it cannot locate the requested content in a single call.
By caching revision trees, we can optimize resource usage.
Modifications:
CachingTreeObjectReaderto cache revision trees and reduce redundant computations.Result: