Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement required components #115

Merged
merged 6 commits into from
Feb 11, 2025
Merged

feat: implement required components #115

merged 6 commits into from
Feb 11, 2025

Conversation

simbleau
Copy link
Member

Closes #100

Copy link
Collaborator

@RobertBrewitz RobertBrewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the examples be updated as well to use required components instead of their bundle counterparts?

@simbleau
Copy link
Member Author

Should the examples be updated as well to use required components instead of their bundle counterparts?

I did that

@RobertBrewitz
Copy link
Collaborator

Should the examples be updated as well to use required components instead of their bundle counterparts?

I did that

To clarify, these examples and lines are still spawning Bundles, if this is intended, I am good with the PR.

examples/text/src/main.rs
35:    commands.spawn(VelloTextBundle {
53:    commands.spawn(VelloTextBundle {

examples/drag_n_drop/src/main.rs
31:    commands.spawn(VelloSvgBundle {
119:            commands.spawn(VelloSvgBundle {
133:            commands.spawn(VelloLottieBundle {
159:            commands.spawn(VelloSvgBundle {
165:            commands.spawn(VelloLottieBundle {

examples/scene_ui/src/main.rs
33:        VelloSceneBundle {

examples/demo/src/main.rs
30:        .spawn(VelloLottieBundle {

@simbleau
Copy link
Member Author

Most of those were intended, however some I did cleanup. :) We're good now

@simbleau simbleau added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit 3a7ed45 Feb 11, 2025
6 checks passed
@simbleau simbleau deleted the simbleau/issue-100 branch February 11, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement required components
2 participants