-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement required components #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the examples be updated as well to use required components instead of their bundle counterparts?
I did that |
To clarify, these examples and lines are still spawning Bundles, if this is intended, I am good with the PR. examples/text/src/main.rs
35: commands.spawn(VelloTextBundle {
53: commands.spawn(VelloTextBundle {
examples/drag_n_drop/src/main.rs
31: commands.spawn(VelloSvgBundle {
119: commands.spawn(VelloSvgBundle {
133: commands.spawn(VelloLottieBundle {
159: commands.spawn(VelloSvgBundle {
165: commands.spawn(VelloLottieBundle {
examples/scene_ui/src/main.rs
33: VelloSceneBundle {
examples/demo/src/main.rs
30: .spawn(VelloLottieBundle { |
9ae8f15
to
31cb2e6
Compare
Most of those were intended, however some I did cleanup. :) We're good now |
Closes #100