Require a VelloView marker for cameras rendering Vello graphics #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out I was unnecessarily redrawing a bunch of static lines every frame. Fixing that solved my performance problems, but I think this PR is still a good change. |
|
I'm in the middle of a bevy 0.15 refactor and will add your changes after the 0.15 upgrade. This might sit for a minute, apologies. |
|
Would you mind rebasing now that the bevy 0.15 upgrade is complete? |
msvbg
force-pushed
the
require-vello-view-marker
branch
from
6e2f705 to
6a5f399
Compare
|
Done! It looks like the cube3d example no longer works, probably due to #93? |
simbleau
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is common for Bevy cameras to mark what graphics features they use using a marker component, such as bloom or SSR, to name a few built-in effects that do this. In my game, I have cameras that don't need any Vello content at all. If I've read the logic correctly, they still pay the tax of running Vello code.
bevy_vello's
render_framesystem is currently the most demanding system in my game, and this PR seems to push it down to second place, although it is quite difficult to measure precisely.Note that this is a breaking change, since users now have to add the
VelloViewcomponent to their camera or nothing will render.