Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Data types and fields pub(crate) #177

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Make Data types and fields pub(crate) #177

merged 1 commit into from
Nov 19, 2024

Conversation

PoignardAzur
Copy link
Contributor

@PoignardAzur PoignardAzur commented Nov 18, 2024 •
edited
Loading

This makes it more clear that these types aren't publicly exported and are meant to be internal types.

DJMcNab
DJMcNab reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also enable unreachable_pub at the same time?

@PoignardAzur PoignardAzur added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit a0dbf96 Nov 19, 2024
20 checks passed
@PoignardAzur PoignardAzur deleted the make_pub_crate branch November 19, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab left review comments

@nicoburns nicoburns nicoburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PoignardAzur @nicoburns @DJMcNab