Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to wgpu 24.0.0 #791

Merged
merged 7 commits into from
Jan 23, 2025
Merged

Update to wgpu 24.0.0 #791

merged 7 commits into from
Jan 23, 2025
+145 −91

Conversation

songhuaixu
Copy link
Contributor

No description provided.

@waywardmonkeys
Copy link
Collaborator

@songhuaixu Thank you for this contribution!

This leads us to an interesting issue which is that we haven't yet released a version that is compatible with Bevy, so we're going to need to hold on this at least until that happens:

https://xi.zulipchat.com/#narrow/channel/197075-gpu/topic/wgpu.20v24.20released

Is there a particular part of this update that you're in need of to have it sooner rather than a bit later?

@songhuaixu
Copy link
Contributor Author

@songhuaixu Thank you for this contribution!

This leads us to an interesting issue which is that we haven't yet released a version that is compatible with Bevy, so we're going to need to hold on this at least until that happens:

https://xi.zulipchat.com/#narrow/channel/197075-gpu/topic/wgpu.20v24.20released

Is there a particular part of this update that you're in need of to have it sooner rather than a bit later?

I can wait for Bevy

DJMcNab
DJMcNab reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few things.

examples/with_winit/Cargo.toml Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
vello/src/util.rs Outdated Show resolved Hide resolved
vello_shaders/src/compile/msl.rs Show resolved Hide resolved
@songhuaixu songhuaixu marked this pull request as draft January 16, 2025 11:09
@songhuaixu songhuaixu marked this pull request as ready for review January 19, 2025 08:29
waywardmonkeys
waywardmonkeys approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that I'm okay with this overall now. It would make sense to just bump things to 24.0.1 now that that is out earlier today.

@DJMcNab DJMcNab enabled auto-merge January 23, 2025 13:03
@DJMcNab
Copy link
Member

DJMcNab commented Jan 23, 2025

Thank you! Thanks also for driving the change to wgpu-profiler

@DJMcNab DJMcNab added this pull request to the merge queue Jan 23, 2025
Merged via the queue into linebender:main with commit 2f08fe7 Jan 23, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab left review comments

@waywardmonkeys waywardmonkeys waywardmonkeys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@songhuaixu @waywardmonkeys @DJMcNab