Add transparency support to render_to_surface. #801
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
reviewed
Jan 27, 2025
| @@ -502,6 +502,7 @@ impl Renderer { | |||
| scene: &Scene, | |||
| surface: &SurfaceTexture, | |||
| params: &RenderParams, | |||
| clear: bool, | |||
There was a problem hiding this comment.
A bare boolean parameter is very rarely understandable. I think the best solution here would be to move clear into being a field of RendererOptions. (We'd need to also then make it a field of Renderer).
Clearly that's not ideal in all cases. I hope that we can remove render_to_surface entirely soon. But that's been planned for probably a year, so...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny PR adds the feature suggested in #549.
It adds transparency support for
render_to_surface, with the addition of being able to render scenes on top of already rendered stuff with this function by giving you the option to choose if you want to clear the screen before drawing via an extra argument called "clear". If the check is true, it clears the screen before drawing the scene; if it is false, it doesn't.