xilem_html: minor improvement in Element::remove_attr (use &str ins…

…tead of `Into<CowStr`) (#129)
linebender · Aug 16, 2023 · e625593 · e625593
1 parent 09271e7
commit e625593
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/crates/xilem_html/src/element/elements.rs b/crates/xilem_html/src/element/elements.rs
@@ -53,10 +53,7 @@ macro_rules! element {
                 self
             }
 
-            pub fn remove_attr(
-                &mut self,
-                name: impl Into<std::borrow::Cow<'static, str>>,
-            ) -> &mut Self {
+            pub fn remove_attr(&mut self, name: &str) -> &mut Self {
                 self.0.remove_attr(name);
                 self
             }

diff --git a/crates/xilem_html/src/element/mod.rs b/crates/xilem_html/src/element/mod.rs
@@ -92,12 +92,12 @@ impl<El, ViewSeq> Element<El, ViewSeq> {
         if let Some(value) = value.into_attribute_value() {
             self.attributes.insert(name, value);
         } else {
-            self.attributes.remove(&name);
+            self.remove_attr(&name);
         }
     }
 
-    pub fn remove_attr(&mut self, name: impl Into<CowStr>) {
-        self.attributes.remove(&name.into());
+    pub fn remove_attr(&mut self, name: &str) {
+        self.attributes.remove(name);
     }
 
     /// Set a function to run after the new view tree has been created.