Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump vello (and wgpu versions) #122

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Bump vello (and wgpu versions) #122

merged 1 commit into from
Aug 7, 2023

Conversation

dfrg
Copy link
Contributor

@dfrg dfrg commented Aug 7, 2023

Updates xilem to the latest vello. Also bumps wgpu to 0.17.0.

This should enable CFF/CFF2 support.

@dfrg
Bump vello (and wgpu versions)
91c34d1 
Updates xilem to the latest vello. Also bumps wgpu to 0.17.0.

This should enable CFF/CFF2 support.
@jplatte
Copy link
Member

jplatte commented Aug 7, 2023

Should the parenthesis in the commit / PR message not close one word earlier? ^^

Philipp-M
Philipp-M approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@Philipp-M Philipp-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Linux, LGTM

jaredoconnell
jaredoconnell approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I tested it and found no issues Linux Fedora Wayland or Mac OS.

@dfrg
Copy link
Contributor Author

dfrg commented Aug 7, 2023

Should the parenthesis in the commit / PR message not close one word earlier? ^^

Oops, yes :) I blame it on late night/weekend work.

@dfrg
Copy link
Contributor Author

dfrg commented Aug 7, 2023

Thanks all for testing on Linux!

@dfrg dfrg merged commit 2f9f5b6 into main Aug 7, 2023
3 checks passed
@dfrg dfrg deleted the bump-vello branch August 7, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredoconnell jaredoconnell jaredoconnell approved these changes

@Philipp-M Philipp-M Philipp-M approved these changes

@nicoburns nicoburns nicoburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dfrg @jplatte @nicoburns @Philipp-M @jaredoconnell