Resolve mismatch between label width and alignment #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This failure was due to a previous experiment with more spaces
Philipp-M
approved these changes
Nov 5, 2024
masonry/src/widget/prose.rs
Outdated
| @@ -11,7 +11,7 @@ use vello::peniko::BlendMode; | |||
| use vello::Scene; | |||
|
|
|||
| use crate::text::{ArcStr, TextBrush, TextWithSelection}; | |||
| use crate::widget::label::LABEL_X_PADDING; | |||
| use crate::widget::label::PROSE_X_PADDING; | |||
There was a problem hiding this comment.
As it's called PROSE_X_PADDING and used here as well, maybe move it here alltogether?
There was a problem hiding this comment.
Lol, I didn't realise I re-used the import from both. I'll address it.
| /// | ||
| /// Note that setting [`alignment`](Prose::alignment) on the result | ||
| /// will be meaningless. | ||
| pub fn inline_prose(content: impl Into<ArcStr>) -> Prose { |
There was a problem hiding this comment.
Maybe span instead as I think it's shorter and similar to the web equivalent?
But inline_prose on the other hand is descriptive.
There was a problem hiding this comment.
I'll add a doc(alias) for now
jaredoconnell
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the alignment was set previously, and the
CrossAxisAlignmentwas notStart, the width Parley believed we were in wouldn't match the width used for Masonry layout. This would lead to weird behaviour.See the diff for the test images in 0a68159 for more context