Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPD-44271 Move if clause inside return #2983

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ling-alan-huang
Copy link
Owner

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@ling-alan-huang
Copy link
Owner Author

java.lang.Exception: Found 16 formatting issues:
1: Simplify lambda statement with single statement: /Users/alan/liferay_code/master/liferay-portal/modules/apps/account/account-admin-web/src/main/java/com/liferay/account/admin/web/internal/servlet/taglib/util/AccountUserActionDropdownItemsProvider.java 55 (Checkstyle:LambdaCheck)
2: Simplify lambda statement with single statement: /Users/alan/liferay_code/master/liferay-portal/modules/apps/commerce/commerce-currency-service/src/main/java/com/liferay/commerce/currency/internal/security/permission/resource/CommerceCurrencyPortletResourcePermissionWrapper.java 30 (Checkstyle:LambdaCheck)
3: Simplify lambda statement with single statement: /Users/alan/liferay_code/master/liferay-portal/modules/apps/commerce/commerce-inventory-service/src/main/java/com/liferay/commerce/inventory/internal/security/permission/resource/CommerceInventoryWarehousePortletResourcePermissionWrapper.java 30 (Checkstyle:LambdaCheck)
4: No need to declare variable "cpOptionSelectDateType" because it is returned right after: /Users/alan/liferay_code/master/liferay-portal/modules/apps/commerce/commerce-product-options-web/src/main/java/com/liferay/commerce/product/options/web/internal/display/context/CPOptionValueDisplayContext.java 102 (Checkstyle:UnnecessaryVariableDeclarationCheck)
5: Simplify lambda statement with single statement: /Users/alan/liferay_code/master/liferay-portal/modules/apps/dynamic-data-mapping/dynamic-data-mapping-form-field-type/src/main/java/com/liferay/dynamic/data/mapping/form/field/type/internal/options/OptionsDDMFormFieldTemplateContextContributor.java 47 (Checkstyle:LambdaCheck)
6: Simplify lambda statement with single statement: /Users/alan/liferay_code/master/liferay-portal/modules/apps/headless/headless-delivery/headless-delivery-impl/src/main/java/com/liferay/headless/delivery/internal/dto/v1_0/converter/StructuredContentDTOConverter.java 295 (Checkstyle:LambdaCheck)
7: No need to declare variable "customizableLayout" because it is returned right after: /Users/alan/liferay_code/master/liferay-portal/modules/apps/layout/layout-api/src/main/java/com/liferay/layout/util/template/LayoutTypeSettingsInspectorUtil.java 50 (Checkstyle:UnnecessaryVariableDeclarationCheck)
8: Simplify lambda statement with single statement: /Users/alan/liferay_code/master/liferay-portal/modules/apps/layout/layout-page-template-item-selector-web/src/main/java/com/liferay/layout/page/template/item/selector/web/internal/display/context/LayoutPageTemplateCollectionsTreeNodeDisplayContext.java 81 (Checkstyle:LambdaCheck)
9: No need to declare variable "lfrIgoogleShowAddAppLink" because it is returned right after: /Users/alan/liferay_code/master/liferay-portal/modules/apps/portlet-configuration/portlet-configuration-sharing-web/src/main/java/com/liferay/portlet/configuration/sharing/web/internal/portlet/configuration/icon/IGooglePortletConfigurationIcon.java 90 (Checkstyle:UnnecessaryVariableDeclarationCheck)
10: No need to declare variable "lfrNetvibesShowAddAppLink" because it is returned right after: /Users/alan/liferay_code/master/liferay-portal/modules/apps/portlet-configuration/portlet-configuration-sharing-web/src/main/java/com/liferay/portlet/configuration/sharing/web/internal/portlet/configuration/icon/NetvibesPortletConfigurationIcon.java 84 (Checkstyle:UnnecessaryVariableDeclarationCheck)
11: No need to declare variable "lfrWidgetShowAddAppLink" because it is returned right after: /Users/alan/liferay_code/master/liferay-portal/modules/apps/portlet-configuration/portlet-configuration-sharing-web/src/main/java/com/liferay/portlet/configuration/sharing/web/internal/portlet/configuration/icon/WidgetPortletConfigurationIcon.java 84 (Checkstyle:UnnecessaryVariableDeclarationCheck)
12: Simplify lambda statement with single statement: /Users/alan/liferay_code/master/liferay-portal/modules/apps/site-navigation/site-navigation-admin-web/src/main/java/com/liferay/site/navigation/admin/web/internal/display/context/SiteNavigationAdminDisplayContext.java 446 (Checkstyle:LambdaCheck)
13: No need to declare variable "trashEnabled" because it is returned right after: /Users/alan/liferay_code/master/liferay-portal/modules/apps/site/site-admin-web/src/main/java/com/liferay/site/admin/web/internal/configuration/admin/display/RecycleBinSiteSettingsConfigurationScreenWrapper.java 82 (Checkstyle:UnnecessaryVariableDeclarationCheck)
14: Simplify lambda statement with single statement: /Users/alan/liferay_code/master/liferay-portal/modules/dxp/apps/portal-workflow-kaleo-forms/portal-workflow-kaleo-forms-web/src/main/java/com/liferay/portal/workflow/kaleo/forms/web/internal/util/KaleoFormsUtil.java 130 (Checkstyle:LambdaCheck)
15: Simplify lambda statement with single statement: /Users/alan/liferay_code/master/liferay-portal/modules/dxp/apps/portal-workflow-kaleo-forms/portal-workflow-kaleo-forms-web/src/main/java/com/liferay/portal/workflow/kaleo/forms/web/internal/util/KaleoFormsUtil.java 487 (Checkstyle:LambdaCheck)
16: Combine the literal strings "com.liferay.arquillian.extension.junit.bridge.junit." and "Arquillian": /Users/alan/liferay_code/master/liferay-portal/portal-test/src/com/liferay/portal/kernel/test/rule/ArquillianUtil.java 32 (Checkstyle:PlusStatementCheck)

@ling-alan-huang ling-alan-huang force-pushed the LPD-44271_20241215_1 branch 3 times, most recently from aad972c to ac79966 Compare December 23, 2024 06:29
@ling-alan-huang ling-alan-huang force-pushed the LPD-44271_20241215_1 branch 2 times, most recently from 09a3cf1 to bef5cd7 Compare February 2, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants