LPD-48736 OSGiCommandsCheck #3141

ling-alan-huang · 2025-02-15T12:52:17Z

No description provided.

ling-alan-huang · 2025-02-18T07:38:40Z

java.lang.Exception: Found 15 formatting issues:
1: Name of class implementing "OSGiCommands" should be the value of "osgi.command.scope" property with "OSGiCommands": /Users/alan/liferay_code/master/liferay-portal/modules/apps/adaptive-media/adaptive-media-document-library-thumbnails/src/main/java/com/liferay/adaptive/media/document/library/thumbnails/internal/osgi/commands/AMThumbnailsOSGiCommands.java 50 (Checkstyle:OSGiCommandsCheck)
2: Name of class implementing "OSGiCommands" should be the value of "osgi.command.scope" property with "OSGiCommands": /Users/alan/liferay_code/master/liferay-portal/modules/apps/address/address-impl/src/main/java/com/liferay/address/internal/osgi/commands/PortalAddressOSGiCommands.java 34 (Checkstyle:OSGiCommandsCheck)
3: Name of class implementing "OSGiCommands" should be the value of "osgi.command.scope" property with "OSGiCommands": /Users/alan/liferay_code/master/liferay-portal/modules/apps/commerce/commerce-product-service/src/main/java/com/liferay/commerce/product/internal/osgi/commands/CPOSGiCommands.java 35 (Checkstyle:OSGiCommandsCheck)
4: Name of class implementing "OSGiCommands" should be the value of "osgi.command.scope" property with "OSGiCommands": /Users/alan/liferay_code/master/liferay-portal/modules/apps/document-library/document-library-service/src/main/java/com/liferay/document/library/internal/osgi/commands/DLStorageQuotaOSGiCommands.java 20 (Checkstyle:OSGiCommandsCheck)
5: Name of class implementing "OSGiCommands" should be the value of "osgi.command.scope" property with "OSGiCommands": /Users/alan/liferay_code/master/liferay-portal/modules/apps/document-library/document-library-service/src/main/java/com/liferay/document/library/internal/osgi/commands/StoreAreaOSGiCommands.java 28 (Checkstyle:OSGiCommandsCheck)
6: Name of class implementing "OSGiCommands" should be the value of "osgi.command.scope" property with "OSGiCommands": /Users/alan/liferay_code/master/liferay-portal/modules/apps/portal-osgi-debug/portal-osgi-debug-declarative-service/src/main/java/com/liferay/portal/osgi/debug/declarative/service/internal/osgi/commands/SoftCircularDependencyOSGiCommands.java 20 (Checkstyle:OSGiCommandsCheck)
7: Name of class implementing "OSGiCommands" should be the value of "osgi.command.scope" property with "OSGiCommands": /Users/alan/liferay_code/master/liferay-portal/modules/apps/portal-osgi-debug/portal-osgi-debug-declarative-service/src/main/java/com/liferay/portal/osgi/debug/declarative/service/internal/osgi/commands/UnsatisfiedComponentOSGiCommands.java 20 (Checkstyle:OSGiCommandsCheck)
8: Name of class implementing "OSGiCommands" should be the value of "osgi.command.scope" property with "OSGiCommands": /Users/alan/liferay_code/master/liferay-portal/modules/apps/portal-osgi-debug/portal-osgi-debug-impl/src/main/java/com/liferay/portal/osgi/debug/internal/osgi/commands/CapabilityOSGiCommands.java 30 (Checkstyle:OSGiCommandsCheck)
9: Name of class implementing "OSGiCommands" should be the value of "osgi.command.scope" property with "OSGiCommands": /Users/alan/liferay_code/master/liferay-portal/modules/apps/portal-osgi-debug/portal-osgi-debug-impl/src/main/java/com/liferay/portal/osgi/debug/internal/osgi/commands/DependencyClosureOSGiCommands.java 29 (Checkstyle:OSGiCommandsCheck)
10: Name of class implementing "OSGiCommands" should be the value of "osgi.command.scope" property with "OSGiCommands": /Users/alan/liferay_code/master/liferay-portal/modules/apps/portal-osgi-debug/portal-osgi-debug-impl/src/main/java/com/liferay/portal/osgi/debug/internal/osgi/commands/SPIProviderOSGiCommands.java 30 (Checkstyle:OSGiCommandsCheck)
11: Name of class implementing "OSGiCommands" should be the value of "osgi.command.scope" property with "OSGiCommands": /Users/alan/liferay_code/master/liferay-portal/modules/apps/portal-osgi-debug/portal-osgi-debug-impl/src/main/java/com/liferay/portal/osgi/debug/internal/osgi/commands/SystemCheckOSGiCommands.java 16 (Checkstyle:OSGiCommandsCheck)
12: Name of class implementing "OSGiCommands" should be the value of "osgi.command.scope" property with "OSGiCommands": /Users/alan/liferay_code/master/liferay-portal/modules/apps/portal-remote/portal-remote-http-whiteboard-debug/src/main/java/com/liferay/portal/remote/http/whiteboard/debug/osgi/commands/CheckServletContextHelperOSGiCommands.java 29 (Checkstyle:OSGiCommandsCheck)
13: Name of class implementing "OSGiCommands" should be the value of "osgi.command.scope" property with "OSGiCommands": /Users/alan/liferay_code/master/liferay-portal/modules/apps/portal-remote/portal-remote-jaxrs-whiteboard-debug/src/main/java/com/liferay/portal/remote/jaxrs/whiteboard/debug/osgi/commands/JaxRsServiceRuntimeOSGiCommands.java 43 (Checkstyle:OSGiCommandsCheck)
14: Name of class implementing "OSGiCommands" should be the value of "osgi.command.scope" property with "OSGiCommands": /Users/alan/liferay_code/master/liferay-portal/modules/apps/portal/portal-upgrade-impl/src/main/java/com/liferay/portal/upgrade/internal/index/updater/osgi/commands/IndexUpdaterOSGiCommands.java 23 (Checkstyle:OSGiCommandsCheck)
15: Name of class implementing "OSGiCommands" should be the value of "osgi.command.scope" property with "OSGiCommands": /Users/alan/liferay_code/master/liferay-portal/modules/apps/portal/portal-upgrade-impl/src/main/java/com/liferay/portal/upgrade/internal/release/osgi/commands/ReleaseManagerOSGiCommands.java 37 (Checkstyle:OSGiCommandsCheck)

ling-alan-huang · 2025-02-18T10:14:18Z

ci:test:sf

ling-alan-huang · 2025-02-18T10:14:22Z

ci:test:relevant

liferay-continuous-integration · 2025-02-18T10:25:56Z

ci:test:upgrade

Invoking upgrade test suite because an upgrade file has been modified.

liferay-continuous-integration · 2025-02-18T10:35:19Z

❌ ci:test:relevant - 0 out of 1 jobs passed in 21 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2423f230040d6af3f711535d58d525def4c8eaa7

Upstream Comparison:

Branch GIT ID: 2423f230040d6af3f711535d58d525def4c8eaa7
Jenkins Build URL: EE Development Acceptance (master) - 1196 - 2025-02-16[04:35:49]

ci:test:relevant - 0 out of 1 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

0 Jobs Passed.
1 Job Failed.

     [exec] > Task :apps:document-library:document-library-service:compileJava FAILED
     [exec] 
     [exec] > Task :apps:frontend-taglib:frontend-taglib-dynamic-section:jar
     [exec] Note: /opt/dev/projects/github/liferay-portal/modules/apps/document-library/document-library-video/src/main/java/com/liferay/document/library/video/internal/servlet/filter/DLVideoEmbedFilter.java uses or overrides a deprecated API.
     [exec] Note: Recompile with -Xlint:deprecation for details.
     [exec] > Task :apps:frontend-taglib:frontend-taglib-dynamic-section:autoUpdateXml SKIPPED
     [exec] > Task :apps:dynamic-data-mapping:dynamic-data-mapping-item-selector-api:autoUpdateXml SKIPPED
     [exec] 
     [exec] > Task :apps:document-library:document-library-video:compileJava
     [exec] 
     [exec] > Task :apps:document-library:document-library-repository-cmis-impl:jar
     [exec] > Task :apps:document-library:document-library-repository-cmis-impl:autoUpdateXml SKIPPED
     [exec] Gradle build finished at 2025-02-18 10:34:06.475.
     [exec] 
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:document-library:document-library-service:compileJava'.
     [exec] > Compilation failed; see the compiler error output for details.
     [exec] 
     [exec] * Try:
     [exec] > Run with --info option to get more log output.
     [exec] > Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:document-library:document-library-service:compileJava'.
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:148)
     [exec]   at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:282)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:146)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:134)
     [exec]   at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
     [exec]   at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51)

For upstream results, click here.

liferay-continuous-integration · 2025-02-18T10:39:21Z

❌ ci:test:upgrade - 0 out of 1 jobs passed in 13 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2423f230040d6af3f711535d58d525def4c8eaa7

Upstream Comparison:

Branch GIT ID: 2423f230040d6af3f711535d58d525def4c8eaa7
Jenkins Build URL: EE Development Acceptance (master) - 1196 - 2025-02-16[04:35:49]

ci:test:upgrade - 0 out of 1 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

0 Jobs Passed.
1 Job Failed.

     [exec] > Task :apps:document-library:document-library-service:compileJava FAILED
     [exec] 
     [exec] > Task :apps:dynamic-data-mapping:dynamic-data-mapping-item-selector-api:autoUpdateXml SKIPPED
     [exec] > Task :apps:frontend-taglib:frontend-taglib-dynamic-section:autoUpdateXml SKIPPED
     [exec] > Task :apps:document-library:document-library-repository-cmis-impl:jar
     [exec] > Task :apps:document-library:document-library-repository-cmis-impl:autoUpdateXml SKIPPED
     [exec] Note: Some input files use or override a deprecated API.
     [exec] Note: Recompile with -Xlint:deprecation for details.
     [exec] Note: Some input files use unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] 
     [exec] > Task :apps:document-library:document-library-video:packageRunBuild
     [exec] yarn run v1.13.0
     [exec] warning package.json: No license field
     [exec] \$ node-scripts build
     [exec] DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
     [exec] 
     [exec] Recommendation: math.div(\$numerator, \$denominator) or calc(\$numerator / \$denominator)
     [exec] 
     [exec] More info and automated migrator: https://sass-lang.com/d/slash-div
     [exec] 
     [exec]    ╷
     [exec] 13 │         \$numerator / \$denominator
     [exec]    │         ^^^^^^^^^^^^^^^^^^^^^^^^^
     [exec]    ╵
     [exec]     ../../../node_modules/@clayui/css/src/scss/functions/_polyfills.scss 13:3           clay-div()
     [exec]     ../../../node_modules/@clayui/css/src/scss/functions/_global-functions.scss 910:15  clay-svg-url()
     [exec]     ../../../node_modules/@clayui/css/src/scss/functions/_global-functions.scss 975:10  clay-icon()
     [exec]     ../../../node_modules/@clayui/css/src/scss/atlas/variables/_forms.scss 247:28       @import
     [exec]     ../../../node_modules/@clayui/css/src/scss/atlas/_variables.scss 14:9               @import
     [exec]     atlas-variables.scss 9:9                                                            @import
     [exec]     src/main/resources/META-INF/resources/css/main.scss 1:9                             root stylesheet
     [exec] 
     [exec] ⌛ Esbuild for main took: 0.099 s
     [exec] DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
     [exec]

For upstream results, click here.

liferay-continuous-integration · 2025-02-18T10:39:44Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 25 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2423f230040d6af3f711535d58d525def4c8eaa7

Sender Branch:

Branch Name: LPD-48736_20250215
Branch GIT ID: 18a4f45168e52973b10ff550ea8b8e36f5503c0d

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2025-02-18T10:41:28Z

Jenkins Build:test-portal-source-format#7003

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:ling-alan-huang#3141

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - ling-alan-huang > ling-alan-huang - PR#3141 - 2025-02-18[02:14:28]

Testray Build ID:144235245

Testray Importer:publish-testray-report#27481

liferay-continuous-integration · 2025-02-18T10:42:45Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6171

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:ling-alan-huang#3141

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - ling-alan-huang > ling-alan-huang - PR#3141 - 2025-02-18[02:14:35]

Testray Build ID:144235251

Testray Importer:publish-testray-report#36374

liferay-continuous-integration · 2025-02-18T10:49:16Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6172

Jenkins Report:jenkins-report.html

Jenkins Suite:upgrade

Pull Request:ling-alan-huang#3141

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:upgrade - ling-alan-huang > ling-alan-huang - PR#3141 - 2025-02-18[02:26:07]

Testray Build ID:144235259

Testray Importer:publish-testray-report#36375

ling-alan-huang · 2025-02-18T11:17:21Z

ci:test:sf

ling-alan-huang · 2025-02-18T11:17:30Z

ci:test:relevant

liferay-continuous-integration · 2025-02-18T11:43:19Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 26 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2423f230040d6af3f711535d58d525def4c8eaa7

Sender Branch:

Branch Name: LPD-48736_20250215
Branch GIT ID: f3a94bbc2ba5f2dc4ef22154a5ac01545844430e

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2025-02-18T11:45:06Z

Jenkins Build:test-portal-source-format#11743

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:ling-alan-huang#3141

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - ling-alan-huang > ling-alan-huang - PR#3141 - 2025-02-18[03:17:31]

Testray Build ID:144268860

Testray Importer:publish-testray-report#44019

liferay-continuous-integration · 2025-02-18T15:07:14Z

✔️ ci:test:stable - 24 out of 24 jobs passed

❌ ci:test:relevant - 101 out of 128 jobs passed in 3 hours 42 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2423f230040d6af3f711535d58d525def4c8eaa7

Upstream Comparison:

Branch GIT ID: 2423f230040d6af3f711535d58d525def4c8eaa7
Jenkins Build URL: EE Development Acceptance (master) - 1196 - 2025-02-16[04:35:49]

ci:test:stable - 24 out of 24 jobs PASSED

24 Successful Jobs:

ci:test:relevant - 101 out of 128 jobs PASSED

27 Failed Jobs:

101 Successful Jobs:

For more details click here.

Failures unique to this pull:

Failures in common with acceptance upstream results at 2423f23:

liferay-continuous-integration · 2025-02-18T15:19:42Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#13106

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:ling-alan-huang#3141

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - ling-alan-huang > ling-alan-huang - PR#3141 - 2025-02-18[03:17:41]

Testray Build ID:144517808

Testray Importer:publish-testray-report#28548

…perty value of osgi.command.function

…ands.java into one class

ling-alan-huang force-pushed the LPD-48736_20250215 branch from e68b477 to 1426b93 Compare February 18, 2025 07:37

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending labels Feb 18, 2025

liferay-continuous-integration added ci:test:upgrade - pending ci:test:relevant - failure and removed ci:test:relevant - pending labels Feb 18, 2025

liferay-continuous-integration added ci:test:upgrade - failure and removed ci:test:upgrade - pending labels Feb 18, 2025

liferay-continuous-integration added ci:test:sf - success and removed ci:test:sf - pending labels Feb 18, 2025

ling-alan-huang force-pushed the LPD-48736_20250215 branch from 18a4f45 to f3a94bb Compare February 18, 2025 11:16

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending and removed ci:test:sf - success ci:test:relevant - failure ci:test:stable - pending labels Feb 18, 2025

liferay-continuous-integration added ci:test:sf - success and removed ci:test:sf - pending labels Feb 18, 2025

ling-alan-huang force-pushed the LPD-48736_20250215 branch from f3a94bb to 207068e Compare February 18, 2025 14:08

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Feb 18, 2025

ling-alan-huang force-pushed the LPD-48736_20250215 branch from 207068e to b717d37 Compare February 22, 2025 18:12

ling-alan-huang added 16 commits March 6, 2025 12:58

LPD-48736 Rename

d719937

LPD-48736 Public method name in *OSGiCommands class should be the pro…

b412256

…perty value of osgi.command.function

LPD-48736 SF

464d42f

LPD-48736 SF

f01fd9c

LPD-48736 SF

633a003

LPD-48736 Check class name

cc65950

LPD-48736 Case insensitive

914240a

LPD-48736 Rename

412b479

LPD-48736 Not needed

f508f58

LPD-48736 Rename

824e220

LPD-48736 Merge DLStorageQuotaOSGiCommands.java and StoreAreaOSGiComm…

452500c

…ands.java into one class

LPD-48736 Rename

73a4d95

LPD-48736 Rename

d08d116

LPD-48736 Not needed

379c3a8

LPD-48736 Rename

9add194

LPD-48736 Rename

97af491

ling-alan-huang force-pushed the LPD-48736_20250215 branch from b717d37 to 97af491 Compare March 6, 2025 04:59

LPD-48736 OSGiCommandsCheck #3141

Are you sure you want to change the base?

LPD-48736 OSGiCommandsCheck #3141

Conversation

ling-alan-huang commented Feb 15, 2025

ling-alan-huang commented Feb 18, 2025

ling-alan-huang commented Feb 18, 2025

ling-alan-huang commented Feb 18, 2025

liferay-continuous-integration commented Feb 18, 2025

liferay-continuous-integration commented Feb 18, 2025

❌ ci:test:relevant - 0 out of 1 jobs passed in 21 minutes

Base Branch:

Upstream Comparison:

1 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

For upstream results, click here.

liferay-continuous-integration commented Feb 18, 2025

❌ ci:test:upgrade - 0 out of 1 jobs passed in 13 minutes

Base Branch:

Upstream Comparison:

1 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

For upstream results, click here.

liferay-continuous-integration commented Feb 18, 2025

✔️ ci:test:sf - 1 out of 1 jobs passed in 25 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Feb 18, 2025

liferay-continuous-integration commented Feb 18, 2025

liferay-continuous-integration commented Feb 18, 2025

ling-alan-huang commented Feb 18, 2025

ling-alan-huang commented Feb 18, 2025

liferay-continuous-integration commented Feb 18, 2025

✔️ ci:test:sf - 1 out of 1 jobs passed in 26 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Feb 18, 2025

liferay-continuous-integration commented Feb 18, 2025

✔️ ci:test:stable - 24 out of 24 jobs passed

❌ ci:test:relevant - 101 out of 128 jobs passed in 3 hours 42 minutes

Base Branch:

Upstream Comparison:

27 Failed Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration commented Feb 18, 2025