Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPD-43790 Remove language keys as they have the same description #3166

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ling-alan-huang
Copy link
Owner

@ling-alan-huang ling-alan-huang commented Feb 21, 2025

Same descriptions found in the following language keys: condition, condition-node
Same descriptions found in the following language keys: end, end-node
Same descriptions found in the following language keys: join, join-node
Same descriptions found in the following language keys: start, start-node
Same descriptions found in the following language keys: state, state-node
Same descriptions found in the following language keys: task, task-node

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@ling-alan-huang
Copy link
Owner Author

ci:help

@liferay-continuous-integration
Copy link
Collaborator

Available CI commands:

ci:close

    Close the pull request.

ci:forward[:force]

    Test the pull request and forward the pull request to brianchandotcom if the required test suites pass for ci:forward or complete for ci:forward:force.

ci:merge[:force]

    Merge in the changes from the subrepo. All tests must pass before this command will successfully run. Optionally use the force flag to bypass failed tests.

ci:reevaluate:[buildID]

    Reevaluate the pull request result from a generated build ID.

ci:reopen

    Reopen the pull request.

ci:report:[testrayBuildID]

    Generates a report of test results categorized into unique and nonunique test failures based on the Testray Analysis Tool.

ci:stop[:suite]

    Stop all currrently running tests. Optionally specify the name of the test suite.

ci:test[:suite]:dryrun

    Generate the job summary of the specified test suite based on the pull request changes. This command will not test the pull request.

ci:test[:suite][:SHA|nocompile|norebase|gist-SHA]

    Test the pull request. Optionally specify the name of the test suite and/or optionally specify the upstream SHA to test against or use "nocompile" to test with a prebuilt bundle or use "norebase" to test without rebasing.

Available test suites:
  •     ci:test:acceptance - Test acceptance tests.
  •     ci:test:acceptance-ce - No description is available.
  •     ci:test:acceptance-dxp - No description is available.
  •     ci:test:accessibility-menu - Test all accessibility menu tests.
  •     ci:test:analytics-cloud-acceptance - No description is available.
  •     ci:test:analytics-cloud-release - No description is available.
  •     ci:test:analytics-cloud-upstream - No description is available.
  •     ci:test:app-servers - Test Deployments on App Servers.
  •     ci:test:auto-tagging - Test Auto Tagging tests.
  •     ci:test:backend - Test backend tests.
  •     ci:test:backend-db2 - Test backend tests on DB2.
  •     ci:test:backend-hypersonic - Test backend tests on Hypersonic.
  •     ci:test:backend-mariadb - Test backend tests on MariaDB.
  •     ci:test:backend-mysql - Test backend tests on MySQL.
  •     ci:test:backend-oracle - Test backend tests on Oracle.
  •     ci:test:backend-postgresql - Test backend tests on Postgres SQL.
  •     ci:test:backend-sqlserver - Test backend tests on SQL Server.
  •     ci:test:bundle - Saves a compiled tomcat bundle.
  •     ci:test:bundles - No description is available.
  •     ci:test:calendar - Test Calendar tests.
  •     ci:test:clustering - Test clustering tests.
  •     ci:test:commerce - Test only Commerce tests.
  •     ci:test:commerce-database - Test only Commerce Database tests.
  •     ci:test:commerce-functional - Test only Commerce functional tests.
  •     ci:test:commerce-integration - Test only Commerce integration tests.
  •     ci:test:commerce-upgrade - No description is available.
  •     ci:test:configuration-framework - Test Configuration Framework component tests.
  •     ci:test:content-management - Test Content Management tests.
  •     ci:test:content-management-playwright - Test Content Management playwright tests.
  •     ci:test:continuous-integration - Test Continuous Integration tests.
  •     ci:test:cookies - Test Cookie Preferences tests.
  •     ci:test:core-functional - Test Core Infra Functional tests
  •     ci:test:customer-solutions - Test all Customer Solutions team tests.
  •     ci:test:data-engine - Test Data Engine functional tests.
  •     ci:test:db-partition - Test Database Partitioning functional tests.
  •     ci:test:dev-tools - Test Dev Tools tests.
  •     ci:test:dl-store - Test Document Library Store tests.
  •     ci:test:drools - Test Drools tests.
  •     ci:test:dummy - No description is available.
  •     ci:test:environments - Test environment acceptance functional tests on all available environment stacks.
  •     ci:test:external-document-repositories - Test External Document Repositories tests.
  •     ci:test:forms - Test forms tests.
  •     ci:test:frontend - Test all Frontend Infra team tests.
  •     ci:test:frontend-client-extensions - Test frontend client extensions tests.
  •     ci:test:frontend-data-set - Test frontend data set tests.
  •     ci:test:frontend-dev-exp - Test frontend developer experience tests.
  •     ci:test:frontend-ui - Test frontend ui tests.
  •     ci:test:gradle-plugins - Test Gradle Plugins tests.
  •     ci:test:headless - Test all headless team tests (integration + playwright + poshi + unit).
  •     ci:test:headless-acceptance - Test headless team acceptance tests considering Headless and REST Builder.
  •     ci:test:headless-api-builder - All tests for Headless API Builder component.
  •     ci:test:headless-api-builder-functional - Functional tests for Headless API Builder component.
  •     ci:test:headless-functional - Headless team functional API tests.
  •     ci:test:headless-object-entry-db-integration - Test Integration Object Entry REST API tests with all the databases
  •     ci:test:headless-object-entry-environments-integration - Test Integration Object Entry REST API tests with all the available environments
  •     ci:test:headless-playwright - Headless team playwright tests.
  •     ci:test:headless-poshi - Headless team poshi tests.
  •     ci:test:headless-staging - Test Staging components tests.
  •     ci:test:headless-staging-custom-db - Test Staging components tests with a custom database.
  •     ci:test:headless-upgrade - Headless upgrade tests.
  •     ci:test:jsf - Test Liferay Faces tests.
  •     ci:test:ldap - Test LDAP tests.
  •     ci:test:license - Compile a release bundle and execute tests for licensing.
  •     ci:test:license-cluster - Compile a release bundle and execute tests for cluster licensing on 32GB slaves.
  •     ci:test:lpkg - Test LPKG tests.
  •     ci:test:mfa - Test Multi Factor Authentication tests.
  •     ci:test:navigation-framework - Test Navigation Framework tests.
  •     ci:test:oauth2 - Test OAuth 2 tests.
  •     ci:test:object - Test Object tests.
  •     ci:test:oidc - Test OpenID Connect tests.
  •     ci:test:page-management - Test all Page Management team tests.
  •     ci:test:page-management-playwright - Test Page Management team playwright tests.
  •     ci:test:password-policies - Test Password Policies tests.
  •     ci:test:platform-experience - Test Platform Experience team tests.
  •     ci:test:platform-experience-acceptance - Test Platform Experience team acceptance tests.
  •     ci:test:platform-experience-accessibility - Test Platform Experience team accessibility framework tests.
  •     ci:test:platform-experience-db-partition - No description is available.
  •     ci:test:playwright - Test all playwright tests.
  •     ci:test:portal-context-path - No description is available.
  •     ci:test:portal-proxy-path - No description is available.
  •     ci:test:portlet-deployment - Test deployment of all demo portlet plugins.
  •     ci:test:project-templates - Test project-templates tests.
  •     ci:test:publications - Test publications tests.
  •     ci:test:publications-as - Test publications tests with different application servers.
  •     ci:test:publications-db - Test publications tests with different databases.
  •     ci:test:publications-db-partition - Test publications functional tests with Database Partitioning.
  •     ci:test:publications-lxc - Test publications tests with Liferay Experience Cloud configurations.
  •     ci:test:relevant - Test relevant changes only.
  •     ci:test:reports - Test Reports tests.
  •     ci:test:saml - Test SAML tests.
  •     ci:test:scim - Test SCIM tests.
  •     ci:test:search - Test search tests with the Elasticsearch 7 search engine.
  •     ci:test:search-as - Test search tests with the Elasticsearch 7 search engine on different application servers.
  •     ci:test:search-db - Test search tests with the Elasticsearch 7 search engine on different databases.
  •     ci:test:search-db-partition - Test search functional tests with Database Partitioning.
  •     ci:test:search-es8-as - Test search tests with the Elasticsearch 8 search engine on different application servers.
  •     ci:test:search-es8-db - Test search tests with the Elasticsearch 8 search engine on different databases.
  •     ci:test:search-es8-remote - Test only search tests with the latest compatible remote Elasticsearch 8 version.
  •     ci:test:search-es8-remote-minimum - Test search tests with the minimum compatible remote Elasticsearch 8 version.
  •     ci:test:search-lxc - Test search tests with the Elasticsearch 7 search engine and Liferay Experience Cloud configurations.
  •     ci:test:search-opensearch2 - Test only search tests with the latest compatible OpenSearch 2 version.
  •     ci:test:search-opensearch2-as - Test search tests with the OpenSearch 2 search engine on different application servers.
  •     ci:test:search-opensearch2-db - Test search tests with the OpenSearch 2 search engine on different databases.
  •     ci:test:search-remote - Test only search tests with the latest compatible remote Elasticsearch 7 version.
  •     ci:test:search-remote-minimum - Test search tests with the minimum compatible remote Elasticsearch 7 version.
  •     ci:test:search-solr - Test search tests with the Solr 8 search engine.
  •     ci:test:search-solr-as - Test search tests with the Solr 8 search engine on different application servers.
  •     ci:test:search-solr-db - Test search tests with the Solr 8 search engine on different databases.
  •     ci:test:security - Test security tests.
  •     ci:test:security-playwright - Test security Playwright tests.
  •     ci:test:service-builder - Test Service Builder tests.
  •     ci:test:service-builder-tester - Tests Service Builder changes against legacy branches.
  •     ci:test:setup-wizard - Test Setup Wizard tests.
  •     ci:test:sf - Test source formatter.
  •     ci:test:site-management - Test Site Management tests.
  •     ci:test:stable - No description is available.
  •     ci:test:startup - Test Portal startup.
  •     ci:test:tck - Test TCK tests.
  •     ci:test:um - Test User Management tests.
  •     ci:test:um-db-partition - No description is available.
  •     ci:test:um-playwright - Test User Management playwright tests.
  •     ci:test:upgrade - Test upgrades against tomcat app server and all supported databases.
  •     ci:test:upgrade-app-servers - Test upgrades against all app servers.
  •     ci:test:upgrade-client - Test upgrade client.
  •     ci:test:upgrade-performance - Test large database for upgrade performance regressions.
  •     ci:test:upgrade-sf - Test Source Formatter's upgrade tests.
  •     ci:test:upstream-dxp - No description is available.
  •     ci:test:workflow - Test Workflow tests.
  •     ci:test:workspaces - No description is available.

For more details, see CI GitHub Commands

@ling-alan-huang
Copy link
Owner Author

ci:test:sf

@ling-alan-huang
Copy link
Owner Author

ci:test:relevant

@ling-alan-huang
Copy link
Owner Author

ci:test:workflow

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bb62b53077c481ec8a0e32b12f44167900c83e40

Sender Branch:

Branch Name: LPD-43790_20250221_2
Branch GIT ID: bd247c80792fa0bdec67c1bfa5e0ca921ec97efa

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 23 out of 24 jobs passed

❌ ci:test:relevant - 27 out of 29 jobs passed in 1 hour 10 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1257401_6574

Base Branch:

Branch Name: master
Branch GIT ID: bb62b53077c481ec8a0e32b12f44167900c83e40

Upstream Comparison:

Branch GIT ID: 85fff55d5489f0035fa628c60a3a104fefe4d473
Jenkins Build URL: EE Development Acceptance (master) - 1199 - 2025-02-19[12:36:13]

ci:test:stable - 23 out of 24 jobs PASSED

1 Failed Jobs:

23 Successful Jobs:
    ci:test:relevant - 27 out of 29 jobs PASSED

    2 Failed Jobs:

    27 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      1. js-unit/1/0
        1. .opt.dev.projects.github.liferay-portal.modules.dxp.apps.portal-workflow.portal-workflow-kaleo-designer-web.test.js.designer.definition-builder.diagram-builder.components.nodes.The ConditionNode component should Be rendered with correct icon and default values for label and description, if they are not set
          Error: expect(element).toHaveTextContent()
          

          Expected element to have text content:
          condition-node
          Received:
          condition
          at Object.<anonymous> (/opt/dev/projects/github/liferay-portal/modules/dxp/apps/portal-workflow/portal-workflow-kaleo-designer-web/test/js/designer/definition-builder/diagram-builder/components/nodes/ConditionNode.js:35:17)
          at Object.asyncJestTest (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:100:37)
          at /opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:43:12
          at new Promise (<anonymous>)
          at mapper (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
          at /opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:73:41
          at processTicksAndRejections (node:internal/process/task_queues:95:5)

      For upstream results, click here.

      @ling-alan-huang
      Copy link
      Owner Author

      ci:test:relevant

      @liferay-continuous-integration
      Copy link
      Collaborator

      @liferay-continuous-integration
      Copy link
      Collaborator

      ❌ ci:test:stable - 23 out of 24 jobs passed

      ❌ ci:test:relevant - 27 out of 29 jobs passed in 1 hour 2 minutes

      Click here for more details.

      This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

      ci:reevaluate:1287401_12603

      Base Branch:

      Branch Name: master
      Branch GIT ID: bb62b53077c481ec8a0e32b12f44167900c83e40

      Upstream Comparison:

      Branch GIT ID: 85fff55d5489f0035fa628c60a3a104fefe4d473
      Jenkins Build URL: EE Development Acceptance (master) - 1199 - 2025-02-19[12:36:13]

      ci:test:stable - 23 out of 24 jobs PASSED

      1 Failed Jobs:

      23 Successful Jobs:
        ci:test:relevant - 27 out of 29 jobs PASSED

        2 Failed Jobs:

        27 Successful Jobs:
          For more details click here.

          Failures unique to this pull:

          1. js-unit/1/0
            1. .opt.dev.projects.github.liferay-portal.modules.dxp.apps.portal-workflow.portal-workflow-kaleo-designer-web.test.js.designer.definition-builder.diagram-builder.components.nodes.The ConditionNode component should Be rendered with correct icon and default values for label and description, if they are not set
              Error: expect(element).toHaveTextContent()
              

              Expected element to have text content:
              condition-node
              Received:
              condition
              at Object.<anonymous> (/opt/dev/projects/github/liferay-portal/modules/dxp/apps/portal-workflow/portal-workflow-kaleo-designer-web/test/js/designer/definition-builder/diagram-builder/components/nodes/ConditionNode.js:35:17)
              at Object.asyncJestTest (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:100:37)
              at /opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:43:12
              at new Promise (<anonymous>)
              at mapper (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
              at /opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:73:41
              at processTicksAndRejections (node:internal/process/task_queues:95:5)

          For upstream results, click here.

          @liferay-continuous-integration
          Copy link
          Collaborator

          ❌ ci:test:workflow - 317 out of 386 jobs passed in 3 hours 43 minutes

          Click here for more details.

          This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

          ci:reevaluate:1327401_6210

          Base Branch:

          Branch Name: master
          Branch GIT ID: bb62b53077c481ec8a0e32b12f44167900c83e40

          Upstream Comparison:

          Branch GIT ID: 85fff55d5489f0035fa628c60a3a104fefe4d473
          Jenkins Build URL: EE Development Acceptance (master) - 1199 - 2025-02-19[12:36:13]

          ci:test:workflow - 317 out of 386 jobs PASSED

          69 Failed Jobs:

          317 Successful Jobs:
            For more details click here.

            Failures unique to this pull:

            1. functional-tomcat90-mysql57/2/11
                   [exec] * What went wrong:
                   [exec] Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)
                   [exec] 
                   [exec] * Try:
                   [exec] > Run with --info or --debug option to get more log output.
                   [exec] > Run with --scan to get full insights.
                   [exec] > Get more help at https://help.gradle.org.
                   [exec] 
                   [exec] * Exception is:
                   [exec] org.gradle.launcher.daemon.client.DaemonDisappearedException: Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)
                   [exec]   at org.gradle.launcher.daemon.client.DaemonClient.handleDaemonDisappearance(DaemonClient.java:274)
                   [exec]   at org.gradle.launcher.daemon.client.DaemonClient.monitorBuild(DaemonClient.java:247)
                   [exec]   at org.gradle.launcher.daemon.client.DaemonClient.executeBuild(DaemonClient.java:202)
                   [exec]   at org.gradle.launcher.daemon.client.SingleUseDaemonClient.execute(SingleUseDaemonClient.java:54)
                   [exec]   at org.gradle.launcher.daemon.client.SingleUseDaemonClient.execute(SingleUseDaemonClient.java:37)
                   [exec]   at org.gradle.launcher.cli.RunBuildAction.run(RunBuildAction.java:57)
                   [exec]   at org.gradle.internal.Actions\$RunnableActionAdapter.execute(Actions.java:167)
                   [exec]   at org.gradle.launcher.cli.DefaultCommandLineActionFactory\$ParseAndBuildAction.execute(DefaultCommandLineActionFactory.java:259)
                   [exec]   at org.gradle.launcher.cli.DefaultCommandLineActionFactory\$ParseAndBuildAction.execute(DefaultCommandLineActionFactory.java:230)
                   [exec]   at org.gradle.launcher.cli.DebugLoggerWarningAction.execute(DebugLoggerWarningAction.java:74)
                   [exec]   at org.gradle.launcher.cli.DebugLoggerWarningAction.execute(DebugLoggerWarningAction.java:30)
                   [exec]   at org.gradle.launcher.cli.WelcomeMessageAction.execute(WelcomeMessageAction.java:96)
                   [exec]   at org.gradle.launcher.cli.WelcomeMessageAction.execute(WelcomeMessageAction.java:40)
                   [exec]   at org.gradle.launcher.cli.NativeServicesInitializingAction.execute(NativeServicesInitializingAction.java:44)
                   [exec]   at org.gradle.launcher.cli.NativeServicesInitializingAction.execute(NativeServicesInitializingAction.java:26)
                   [exec]   at org.gradle.launcher.cli.ExceptionReportingAction.execute(ExceptionReportingAction.java:41)
                   [exec]   at org.gradle.launcher.cli.ExceptionReportingAction.execute(ExceptionReportingAction.java:26)
              1. ...
            2. semantic-versioning/0/0

              Please fix semantic versioning on ling-alan-huang/LPD-43790_20250221_2

                   [exec]       +   access     protected
                   [exec]       +   return     void
                   [exec]     +   method     processConcurrently(java.lang.String,com.liferay.petra.function.UnsafeFunction,com.liferay.petra.function.UnsafeConsumer,java.lang.String)
                   [exec]       +   access     protected
                   [exec]       +   return     void
                   [exec]     +   method     processConcurrently(java.lang.String,java.lang.String,com.liferay.petra.function.UnsafeFunction,com.liferay.petra.function.UnsafeBiConsumer,java.lang.String)
                   [exec]       +   access     protected
                   [exec]       +   return     void
                   [exec]     +   method     removePrimaryKey(java.lang.String)
                   [exec]       +   access     protected
                   [exec]       +   return     void
                   [exec]     +   method     runSQL(com.liferay.portal.kernel.dao.db.DBTypeToSQLMap)
                   [exec]       +   return     void
                   [exec]     +   method     runSQL(java.lang.String)
                   [exec]       +   return     void
                   [exec]     +   method     runSQL(java.lang.String[])
                   [exec]       +   return     void
                   [exec]     +   method     runSQL(java.sql.Connection,java.lang.String)
                   [exec]       +   return     void
                   [exec]     +   method     runSQLFile(java.lang.String)
                   [exec]       +   return     void
                   [exec]     +   method     runSQLFile(java.lang.String,boolean)
                   [exec]       +   return     void
                   [exec]     +   method     runSQLTemplate(java.lang.String)
                   [exec]       +   return     void
                   [exec]     +   method     runSQLTemplate(java.lang.String,boolean)
                   [exec]       +   return     void
                   [exec]     +   method     runSQLTemplateString(java.lang.String,boolean)
                   [exec]       +   return     void
                   [exec]     +   method     toString()
                   [exec]       +   return     java.lang.String
                   [exec]     +   method     upgrade()
                   [exec]       +   return     void
                   [exec]     +   method     upgrade(com.liferay.portal.kernel.upgrade.UpgradeProcess)
                   [exec]       +   return     void
                   [exec]   -   version    24.1.0
                   [exec]   +   version    24.2.0
                   [exec] [Baseline Report] Mode: diff (persisted)
                   [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/156.0.0/e95d9badef074189fddf718c5ffc2b39d37a9b50/com.liferay.portal.kernel-156.0.0.jar

              1. com.liferay.jenkins.JenkinsLogAsserterTest
            3. ...

            @liferay-continuous-integration
            Copy link
            Collaborator

            @liferay-continuous-integration
            Copy link
            Collaborator

            Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
            Projects
            None yet
            Development

            Successfully merging this pull request may close these issues.

            2 participants