-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : i18n #94
Merged
Merged
fix : i18n #94
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6304977
refactor : `storeParams` now working properly
kabir-afk 94aaa8d
chore: passing message to execute i18n natively inside sw/bg.js
kabir-afk 5691368
reverting to banana.i18n
kabir-afk 9386741
refactor : sending message from popup to sw/bg.sj when banana.i18n is…
kabir-afk d33217a
fix : implemented the same message passing functionality as in popup
kabir-afk 53c6bac
refactor : updated how `SignItCoreContent()` is called
kabir-afk 7df1c11
Merge branch 'lingua-libre:master' into i18n
kabir-afk 2f1813c
refactored banana.i18n to capture multiple arguments when many place…
kabir-afk 4407699
refactor: implemented the same message passing i18n functionality
kabir-afk 9dfaa56
refactor: used HTML instead of text for `videosPanelNoVideoEmpty`
kabir-afk d3bd590
removed unnecessary lines
kabir-afk 5793669
storing banana and sourceMap no longer needed
kabir-afk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we logging on console ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is legacy, for when i inspected, to know to which file the following logs were related to. Ca be removed if needed