Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor : i18n now working in FF #96

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

kabir-afk
Copy link
Collaborator

normalizeMessage function was interfering with the message , so moved it before function was called

ormalizeMessageunction was interfering with the message , so moved it before function was called
@kabir-afk
Copy link
Collaborator Author

Ignore the commit message . I was trying to use backticks in CLI and aparently it didn't work out 😅

@hugolpz hugolpz added this to the GSoC 2024 milestone Jun 17, 2024
@hugolpz hugolpz added the Purify Clean up code, remove obsolete, optimize label Jun 17, 2024
@Ishan-Saini
Copy link
Collaborator

LGTM

@kabir-afk
Copy link
Collaborator Author

@hugolpz updated the variable names as asked in #94

Copy link
Member

@hugolpz hugolpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming variables : 👍🏼

@Ishan-Saini Ishan-Saini merged commit 328cbef into lingua-libre:master Jun 17, 2024
@kabir-afk kabir-afk deleted the chore/i18n branch June 18, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Purify Clean up code, remove obsolete, optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants