Fix primary key constraint for nullable keys

linkedin · Jul 8, 2024 · ccd0cda · ccd0cda
1 parent c3fa16a
commit ccd0cda
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/hoptimator-catalog/src/main/java/com/linkedin/hoptimator/catalog/ScriptImplementor.java b/hoptimator-catalog/src/main/java/com/linkedin/hoptimator/catalog/ScriptImplementor.java
@@ -170,7 +170,7 @@ public SqlNode visit(SqlCall call) {
    * Implements a CREATE TABLE...WITH... DDL statement.
    *
    * N.B. the following magic:
-   *  - field 'KEY' is treated as a PRIMARY KEY
+   *  - non-nullable field 'KEY' is treated as a PRIMARY KEY
    */
   class ConnectorImplementor implements ScriptImplementor {
     private final String database;
@@ -192,7 +192,8 @@ public void implement(SqlWriter w) {
       (new CompoundIdentifierImplementor(database, name)).implement(w);
       SqlWriter.Frame frame1 = w.startList("(", ")");
       (new RowTypeSpecImplementor(rowType)).implement(w);
-      if (rowType.getField("KEY", true, false) != null) {
+      RelDataTypeField key = rowType.getField("KEY", true, false);
+      if (key != null && key.getType().isNullable() == false) {
         w.sep(",");
         w.literal("PRIMARY KEY (KEY) NOT ENFORCED");
       }

diff --git a/...ka-adapter/src/main/java/com/linkedin/hoptimator/catalog/kafka/RawKafkaSchemaFactory.java b/...ka-adapter/src/main/java/com/linkedin/hoptimator/catalog/kafka/RawKafkaSchemaFactory.java
@@ -31,8 +31,9 @@ public Schema create(SchemaPlus parentSchema, String name, Map<String, Object> o
       .with("KEY", DataType.VARCHAR);
     ConfigProvider connectorConfigProvider = ConfigProvider.from(clientConfig)
       .withPrefix("properties.")
-      .with("connector", "upsert-kafka")
+      .with("connector", "kafka")
       .with("key.format", "csv")
+      .with("key.fields", "KEY")
       .with("value.format", "csv")
       .with("value.fields-include", "EXCEPT_KEY")
       .with("topic", x -> x);