Load from JDBC #71
Merged
Load from JDBC #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryannedolan
force-pushed
the
load-from-jdbc
branch
2 times, most recently
from
b4704e3 to
3ab6c4a
Compare
ryannedolan
force-pushed
the
load-from-jdbc
branch
from
3ab6c4a to
4fb0254
Compare
ehoner
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support loading the catalog via JDBC urls.
Support loading the catalog from a Calcite Schema.
Details
Previously, we required a Calcite model file (e.g.
model.yaml) to load the catalog. We still support this, but now we expect to load model files via the urljdbc:calcite:model=.... In addition, any JDBC url theoretically works (tho the catalog thus loaded may not be useful).Looking ahead, we plan to restructure the Catalog API to enable the use of arbitrary JDBC drivers. Today, we only support catalogs specifically written for Hoptimator.
Testing
Existing integration tests should pass.