Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract forward/backward core computation bits outside of torch autograd context for easy reuse #178

Merged
merged 5 commits into from
Aug 31, 2024

Conversation

qingquansong
Copy link
Collaborator

@qingquansong qingquansong commented Aug 30, 2024

Summary

Extract forward/backward core computation bits outside of torch autograd context for easy reuse. This is beneficial for lightning thunder integration and the reuse of kernel in other context.

Doubled checked the speed and memory usage, within variance range, no degradation

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@qingquansong qingquansong changed the title [WIP] Extract FLCE core computation bits out for easy reuse outside of torch autograd context [WIP] Extract forward/backward core computation bits outside of torch autograd context for easy reuse Aug 30, 2024
@lancerts lancerts requested a review from ByronHsu August 30, 2024 15:38
@qingquansong qingquansong changed the title [WIP] Extract forward/backward core computation bits outside of torch autograd context for easy reuse Extract forward/backward core computation bits outside of torch autograd context for easy reuse Aug 30, 2024
@ByronHsu
Copy link
Collaborator

cc @t-vi LGTM

@qingquansong qingquansong merged commit 51060b0 into main Aug 31, 2024
2 checks passed
@qingquansong qingquansong deleted the qsong/refactor branch August 31, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants