Refactor Temperature Scaling in Distillation Loss #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin362667
changed the title
austin362667
changed the title
ByronHsu
approved these changes
Dec 10, 2024
|
please resolve the conflict |
austin362667
force-pushed
the
austin362667/refactor_distill_temperature
branch
from
d66f4d1 to
25822f1
Compare
|
@ByronHsu Sorry for the late response. Conflict addressed. Thank you~ |
lancerts
previously approved these changes
Dec 11, 2024
Signed-off-by: Austin Liu <[email protected]>
austin362667
force-pushed
the
austin362667/refactor_distill_temperature
branch
from
a86d24e to
2227fe1
Compare
|
Lgtm |
Tcc0403
previously approved these changes
Dec 31, 2024
Signed-off-by: Austin Liu <[email protected]>
Tcc0403
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addressed the part of issue raised in #441
Moving the scale temperature outside the
distillation_loss_fnis fine as well. Keep theloss_fnsimpler, and the rest can be handled in theforwardfunction beforehand. Thanks to the advice by @Tcc0403Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence