Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] use a valid hexadecimal string instead of a placeholder #535

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

faaany
Copy link
Collaborator

@faaany faaany commented Jan 22, 2025

Summary

In the latest code of get_cache_manager of the triton library (https://github.com/triton-lang/triton/blob/1bb8b8055c81f6bb85055645a20e0dbd27d5295f/python/triton/runtime/cache.py#L261), the key needs to be a valid hexadecimal string, otherwise the test will fail.

This PR fixes the issue by using a valid hex string instead of a placeholder.

Testing Done

The test passes both on CUDA and XPU.

========================================================== PASSES ===========================================================
================================================== short test summary info ==================================================
PASSED test/triton/test_triton_monkey_patch.py::test_import_custom_cache_manager
=============================================== 1 passed, 1 warning in 0.12s ================================================

On Intel(R) Data Center GPU Max 1550 and NV GPU A100

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@faaany faaany requested a review from ByronHsu January 22, 2025 06:24
@faaany
Copy link
Collaborator Author

faaany commented Jan 22, 2025

@sywangyi @yao-matrix

@faaany faaany mentioned this pull request Jan 22, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant